This modal allows blocking users. Only users that are not blocked by the viewer can be blocked.
Depends on D4312
Details
Details
- Reviewers
• jacek atul - Commits
- rCOMMcbbc1a7d1981: [web] Introduce block users modal
Render the modal and check if blocking users works correctly.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Doesn't need to be addressed in this diff, but we should probably style the Button to match (roughly) what we have in the RelationshipPromptButton component.
| web/settings/relationship/block-users-modal.react.js | ||
|---|---|---|
| 12–14 ↗ | (On Diff #13628) | Nit: I think it might make sense to position this Props type immediately above the corresponding component (eg line 20). |
| 25 ↗ | (On Diff #13628) | Wonder if this component should be renamed something more generic... eg UsersListActionModal or something? Just because it's a bit weird the AddUsersListModal is presenting a view labeled Block users |
| web/settings/relationship/block-users-modal.react.js | ||
|---|---|---|
| 25 ↗ | (On Diff #13628) | If you feel strongly I can rename it, but the current name also makes sense: we add user to blocked list. This is consistent with BlockedListModal in other place. |