This modal allows adding new friends. Only users that do not have a relationship with viewer or are blocked are displayed as potential friends.
Depends on D4311
Details
Details
- Reviewers
• jacek atul - Commits
- rCOMM4e6518437d65: [web] Introduce add friends modal
Render the modal and check if sending new friend requests work correctly.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| web/settings/relationship/add-friends-modal.react.js | ||
|---|---|---|
| 17 ↗ | (On Diff #13627) | We don't want to show friends - because they are already added. |
| 18–19 ↗ | (On Diff #13627) | Users that blocked the viewer should first unblock the viewer to receive a request |
| 20 ↗ | (On Diff #13627) | If the request is already sent, there's no sense to send it again |
| 21 ↗ | (On Diff #13627) | We can consider displaying users that sent a request, but it is already possible to accept the request from friend-list-modal |
Comment Actions
Personally, I think that users should appear "symmetrically" (one row per user) whether or not they've been "added." I think that the pill design makes sense in the context of the NewThread screen, but not sure about this modal.
I'm guessing that this is what we have on Figma/have decided on, but think we should definitely re-visit the designs for this screen when we get the chance.
Comment Actions
Agree with @atul – this makes sense for NewThread on web/mobile, a bit less sense for AddFriendsModal on native, and even less sense here (where we have plenty of screen real estate). With that said, I agree we should proceed here – it's easier to use the same design everywhere, and we need to move forward on reaching feature parity with native here
Comment Actions
I created a task https://linear.app/comm/issue/ENG-1292/revisit-new-friends-modal-design-on-web where we can discuss what a better design might look like. The current solution is a result of non-existent designs for this feature and consistency with other places.