Page MenuHomePhabricator

[web] Make button size consistent between variants
ClosedPublic

Authored by tomek on Jun 24 2022, 8:23 AM.
Tags
None
Referenced Files
F3487643: D4353.diff
Wed, Dec 18, 8:35 AM
Unknown Object (File)
Sun, Dec 15, 4:53 PM
Unknown Object (File)
Sun, Dec 15, 4:53 PM
Unknown Object (File)
Wed, Dec 11, 12:57 AM
Unknown Object (File)
Sat, Dec 7, 5:29 AM
Unknown Object (File)
Mon, Nov 18, 11:38 PM
Unknown Object (File)
Mon, Nov 18, 8:49 PM
Unknown Object (File)
Mon, Nov 18, 8:47 PM
Subscribers

Details

Summary

Our button has different size depending on the variant, because secondary button has a border that increases its size. The issue isn't usually noticeable, but can be detected by using the debugger. It becomes visible when secondary and primary buttons are displayed in the same line.
The solution is for button to always have a border, which is transparent when the button is primary.

Test Plan

Checked in a couple of places if it still looks ok. There are places when sizing is slightly changed, because primary button is 2 pixels bigger, but the layout is ok in every place.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek requested review of this revision.Jun 24 2022, 8:28 AM

Yup, this makes sense to me. I think the difference in border size was overlooked in D3057, but nice catch!

This revision is now accepted and ready to land.Jun 24 2022, 9:56 AM