HomePhabricator
Diffusion Comm 1361796b7f3f

[backup client] Refactor ws creation

Description

[backup client] Refactor ws creation

Summary:
I found a nice way to simplify the websocket creation on the backup client, that will work even better with the future diffs. get_log_ws_response functions has been merged inside the new create_log_ws_connection function, that is used by both log upload and download.

Depends on D10984

Test Plan: Run the backup integration tests.

Reviewers: marcin, bartek, kamil

Reviewed By: bartek, kamil

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D10985

Details

Provenance
Michal Gniadek <michal.gniadek@swmansion.com>Authored on Feb 5 2024, 7:06 AM
Reviewer
bartek
Differential Revision
D10985: [backup client] Refactor ws creation
Parents
rCOMMf35f6563af5a: [backup client] Merge errors
Branches
Unknown
Tags
Unknown

Event Timeline

Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMM1361796b7f3f: [backup client] Refactor ws creation (authored by Michal Gniadek <michal.gniadek@swmansion.com>).Feb 23 2024, 9:01 AM