Paths

Table of Contentst

[backup client] Merge errors
ClosedPublic
Actions

Authored by michal on Feb 7 2024, 9:36 AM.

Details

Reviewers

marcin
bartek
kamil

Commits

rCOMMf35f6563af5a: [backup client] Merge errors

Summary

Next diffs would introduce a lot of variant repetition between Error and WSError so I decided to merge them together and simplify.

Test Plan

cargo check

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Feb 7 2024, 9:36 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 7 2024, 9:36 AM

michal added a child revision: D10985: [backup client] Refactor ws creation.Feb 7 2024, 9:38 AM

Harbormaster completed remote builds in B26622: Diff 36788.Feb 7 2024, 9:52 AM

michal requested review of this revision.Feb 7 2024, 9:52 AM

kamil accepted this revision.Feb 9 2024, 3:02 AM

This revision is now accepted and ready to land.Feb 9 2024, 3:02 AM

bartek accepted this revision.Feb 9 2024, 7:25 AM

Closed by commit rCOMMf35f6563af5a: [backup client] Merge errors (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyFeb 23 2024, 8:45 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMf35f6563af5a: [backup client] Merge errors.

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

src/

backup/

upload_handler.rs

11 lines

shared/

backup_client/

src/

lib.rs

46 lines

Diff 37532

View Options

native/native_rust_library/src/backup/upload_handler.rs