HomePhabricator
Diffusion Comm 1374f358843d

[web] Added show/hide password button.

Description

[web] Added show/hide password button.

Summary:
Linear issue: https://linear.app/comm/issue/ENG-2050/add-see-password-button-on-the-login-page-and-dont-clear-text-inputs
I've added show/hide password button on tight side of password input in login screen.
I've added new "in-between" components wrapping regular Input/TextInput. In those components I used state
to keep track of button state.
Question:
Should we clear username and password after unsuccessful login?
If we have "show password" as an option I don't think it's necessary, but it's up to you.

Test Plan:
Built app.
Tested app in web and native, both iOS and Android.

Reviewers: tomek, ashoat, atul, kamil, marcin, ginsu

Reviewed By: tomek, ashoat, kamil

Subscribers: abosh, marcin, kamil, atul, ashoat, tomek

Differential Revision: https://phab.comm.dev/D5453

Details

Provenance
przemekAuthored on Oct 25 2022, 6:26 AM
Reviewer
tomek
Differential Revision
D5453: [web] Added show/hide password button.
Parents
rCOMM8082920bcab0: [native] Refactor app-navigator.js
Branches
Unknown
Tags
Unknown