- User Since
- Oct 6 2022, 6:43 AM (34 w, 4 d)
Feb 8 2023
Deleted comment as it was redundant.
Feb 3 2023
On another note. I think @tomek has a day off today.
Deleted unnecessary props.
Feb 2 2023
Small fix. Rebase and moved comment around.
Small fix. Did something wrong while rebasing and comment was not updated.
Moved the logic to separate function. It's places in lib, as it should also be used in web. We have task for that: https://linear.app/comm/issue/ENG-2891/refactor-some-of-the-native-typeahead-creation-logic-and-make-web
I've tested a lot and it works we default to using state, if values in class fields are null.
Fixing and responding to reviewer
I've tried out a lot of solutions. Process and thoughts documented here: https://linear.app/comm/issue/ENG-2890/issue-with-typeahead-flickering-while-the-user-types
Sorry for that, something hasn't refreshed properly apparently.
We need controlSelection set to true in first setter as that's what Android uses.
Tested on iOS and it doesn't affect behaviour.
Also changed control selection to false in first setState.
Previously it was set to true, but it didn't affect app behaviour really.
This way it matches comment.
Feb 1 2023
if -> if else.
Going with sleep(100), waiting for animation flash was unreliable and undeterministic.
Combined conditionals. That logic should be refactoed into seperate functions as it's quire similar to the web counterpart anyway. I've created the task for that: https://linear.app/comm/issue/ENG-2891/refactor-some-of-the-native-typeahead-creation-logic-and-make-web
I'd rather do it after native typeahead is landed as it has higher prio.
Jan 31 2023
Mostly refactor. Respond to reviewers.
Responding to review and introducing hack allowing us for correct selection after typeahead is clicked.
Huge changes here. Explantions in code comments as the solutions are terribly hacky.
small fix - the condition was wrong
I've tested the app in simulator, which is not ideal, but probably less time consuming than dealign with physcial build right now, and the performance seems identical using master branch, or branch with typeahead feature. I've pasted huge message into chat input bar, and hasn't spotted any lag when it comes to typeahead showing or updating.
Jan 29 2023
Responding to review.
Jan 27 2023
Jan 26 2023
Fixed typos and revised text.
Updated comment. I feel like now it's really exhaustive explantion of both the bug and fix.
Or at least as exhaustive as comment can get.
Looks great apart from text color concern
Added comment justifying GestureHandler
Jan 25 2023
Cleaned up and added PanGestureHandler so the component still takes pan/scroll events even ig it's not scrollable
Jan 24 2023
Jan 20 2023
Jan 19 2023
Jan 13 2023
No, I'll do it right now
Jan 12 2023