Add a button that will be used in community drawer for navigating to chats subchannels modal.
Related issue
The same button on native: D6001
Details
Details
- Reviewers
• przemek michal ginsu tomek - Commits
- rCOMMfee7aa83830a: [web] Add subchannels button
Added button to ChatThreadListItem and checked that pressing it opens the subchannels modal
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| web/sidebar/subchannels-button.react.js | ||
|---|---|---|
| 30–37 ↗ | (On Diff #20568) | A lot of wrappers here, can't we simplify it? |
| web/sidebar/subchannels-button.react.js | ||
|---|---|---|
| 30–37 ↗ | (On Diff #20568) | I should have given className={css.wrapper} to Button, but actually I tested it and somehow it's not needed... So going to just remove the wrapper |
| web/sidebar/subchannels-button.css | ||
|---|---|---|
| 1–18 ↗ | (On Diff #20675) | I think we should use hardcoded font sizes/weights. Check web/typography.css for available css variables.; |
Comment Actions
Looks great apart from text color concern
| web/sidebar/subchannels-button.css | ||
|---|---|---|
| 15 ↗ | (On Diff #21076) | Why is this color so dark? Correct me if I'm wrong, but in designs we're using white for that: https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=7332%3A144407&t=VHPLMWEzFLtTEfig-0 It might be the case that I missed something in discussion between you and designers |
| web/sidebar/subchannels-button.css | ||
|---|---|---|
| 15 ↗ | (On Diff #21076) | That was written couple of design iterations ago, when this was the colour used for this button. |