Page MenuHomePhabricator

[web] Add subchannels button

Authored by inka on Jan 4 2023, 5:08 AM.
Referenced Files
Unknown Object (File)
Tue, Feb 28, 10:13 AM
Unknown Object (File)
Tue, Feb 28, 9:51 AM
Unknown Object (File)
Tue, Feb 28, 3:17 AM
Unknown Object (File)
Tue, Feb 28, 2:59 AM
Unknown Object (File)
Mon, Feb 27, 5:43 PM
Unknown Object (File)
Jan 30 2023, 2:08 AM
Unknown Object (File)
Jan 26 2023, 8:11 AM
Unknown Object (File)
Jan 23 2023, 7:42 AM



Add a button that will be used in community drawer for navigating to chats subchannels modal.
Related issue
The same button on native: D6001

Test Plan

Added button to ChatThreadListItem and checked that pressing it opens the subchannels modal

Diff Detail

rCOMM Comm
Lint Not Applicable
Tests Not Applicable

Event Timeline

inka requested review of this revision.Jan 4 2023, 5:22 AM
30–37 ↗(On Diff #20568)

A lot of wrappers here, can't we simplify it?

Remove wrapper. Turns out it didn't do anything...

30–37 ↗(On Diff #20568)

I should have given className={css.wrapper} to Button, but actually I tested it and somehow it's not needed... So going to just remove the wrapper

1–18 ↗(On Diff #20675)

I think we should use hardcoded font sizes/weights. Check web/typography.css for available css variables.;

use web/typography.css values

Looks great apart from text color concern

15 ↗(On Diff #21076)

Why is this color so dark? Correct me if I'm wrong, but in designs we're using white for that:

It might be the case that I missed something in discussion between you and designers

This revision is now accepted and ready to land.Jan 26 2023, 3:40 AM
15 ↗(On Diff #21076)

That was written couple of design iterations ago, when this was the colour used for this button.
The designs keep changing, and because of that I will revisit all of styling in this issue, at the end of implementing the drawer.

This revision now requires review to proceed.Jan 27 2023, 2:10 AM
This revision is now accepted and ready to land.Jan 30 2023, 4:08 AM
This revision was automatically updated to reflect the committed changes.