Page MenuHomePhabricator

[web] Highlight drawer items

Authored by inka on Jan 25 2023, 2:48 AM.
Referenced Files
Unknown Object (File)
Jan 28 2023, 9:10 AM
Unknown Object (File)
Jan 26 2023, 3:20 AM
F343808: Screen Recording 2023-01-25 at
Jan 25 2023, 2:50 AM



Drawer items are supposed to be highlighted in the Chat tab, and not highlighted in the Calendar tab. The Apps tab and user settings tabs for now behave like the Chat tab, because it is still being discussed what we want to do there (

Test Plan

Run the web app, check that drawer items are highlighted in the Chat, and are not in the Calendar App.

Diff Detail

rCOMM Comm
Lint Not Applicable
Tests Not Applicable

Event Timeline

inka requested review of this revision.Jan 25 2023, 3:02 AM

Looks ok, but I think we should reconsider the design a little bit. For me, it feels like clicking on a community in calendar app should result in the community being highlighted.

This revision is now accepted and ready to land.Jan 26 2023, 6:37 AM

I agree that the community should be highlighted when pressed in the calendar

Okay, i created an issue to ask the design team how they want it done.