[web] Move navigation panel from the sidebar to a topbar
AbandonedPublic
Actions

Authored by inka on Jan 22 2023, 10:18 AM.

Details

Reviewers

• przemek
michal
bartek

Summary

Linear issue: https://linear.app/comm/issue/ENG-2739/move-navigationpanel-from-the-sidebar-to-a-top-bar
Due to this change the LeftLayoutAside is no longer needed, and the styles for the AppSwitcher, SettingsSwitcher and NavigationPanel should be moved out of left-layout-aside.css, and more importantly all of those should be moved out of web/sidebar. But this diff is quite big as it is, so I'll do that in following diffs.

Test Plan

Run web app, check that the top bar displayes correctly in Inbox and in Settings. Check that calendar filters display correctly, check that removing the calendar app works fine.

Diff Detail

Repository

rCOMM Comm

Branch

inka/community_drawer_web

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Jan 22 2023, 10:18 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 22 2023, 10:18 AM

inka edited the summary of this revision. (Show Details)Jan 22 2023, 10:20 AM

inka attached a referenced file: F339270: Screen Recording 2023-01-22 at 19.19.01.mov. (Show Details)

inka added a parent revision: D6164: [web] Add community drawer to CommunityPicker.Jan 22 2023, 10:25 AM

Harbormaster completed remote builds in B15520: Diff 21169.Jan 22 2023, 10:33 AM

inka requested review of this revision.Jan 22 2023, 10:33 AM

inka retitled this revision from Move navigation panel from the sidebar to a topbar to [web] Move navigation panel from the sidebar to a topbar.Jan 22 2023, 11:01 AM

inka mentioned this in D6336: [web] Remove LeftLayoutAside.Jan 22 2023, 11:05 AM

inka added a child revision: D6336: [web] Remove LeftLayoutAside.Jan 22 2023, 11:06 AM

inka edited the summary of this revision. (Show Details)Jan 22 2023, 11:18 AM

inka edited the summary of this revision. (Show Details)

inka mentioned this in D6337: [web] Move topbar related code out of web/sidebar.Jan 22 2023, 11:22 AM

inka planned changes to this revision.Jan 23 2023, 5:58 AM

The settings tab is actually supposed to stay as it was, I'll have to do this differently

inka removed a child revision: D6336: [web] Remove LeftLayoutAside.Jan 23 2023, 10:24 AM