Page MenuHomePhabricator
Differential D6337

[web] Move topbar related code out of web/sidebar
AbandonedPublic
Actions

Authored by inka on Jan 22 2023, 11:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 9, 1:13 AM
Unknown Object (File)
Tue, Apr 8, 10:42 PM
Unknown Object (File)
Tue, Apr 8, 5:24 PM
Unknown Object (File)
Mar 17 2025, 7:15 AM
Unknown Object (File)
Mar 17 2025, 7:15 AM
Unknown Object (File)
Mar 17 2025, 7:03 AM
Unknown Object (File)
Feb 13 2025, 2:32 PM
Unknown Object (File)
Feb 13 2025, 2:30 PM
View All 61 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
bartek
• przemek
michal
Summary

Since D6335 the AppSwitcher, SettingsSwitcher and NavigationPanel are no longer in a sidebar, but in a topbar. So the code related to them had to be moved outside of web/sidebar. Moreover since D6336 the LeftLayoutAside doesn't exist
anymore, so the left-layout-aside.css file had been renamed to topbar.css.

Test Plan

Run the web app, check that the topbar displayes correctly.

Diff Detail

Repository
rCOMM Comm
Branch
inka/community_drawer_web
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

Diff 21172

View Options

web/app.react.js

FROM rust:1.67 as builder FROM rust:1.67 as builder
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
build-essential cmake git libgtest-dev libssl-dev zlib1g-dev \ build-essential cmake git libgtest-dev libssl-dev zlib1g-dev \
&& rm -rf /var/lib/apt/lists/* \ && rm -rf /var/lib/apt/lists/* \
&& mkdir -p /home/root/app/ && mkdir -p /home/root/app/
WORKDIR /home/root/app WORKDIR /home/root/app
# Install more recent version of protobuf, must be ran as root # Install more recent version of protobuf, must be ran as root
COPY scripts/install_protobuf.sh ../../scripts/install_protobuf.sh COPY scripts/install_protobuf.sh ../../scripts/install_protobuf.sh
RUN ../../scripts/install_protobuf.sh RUN ../../scripts/install_protobuf.sh
RUN mkdir -p /home/comm/app/identity RUN mkdir -p /home/comm/app/identity
WORKDIR /home/comm/app/identity WORKDIR /home/comm/app/identity
RUN cargo init --bin
COPY services/identity/Cargo.toml services/identity/Cargo.lock ./
COPY shared/ ../../shared/
# Cache build dependencies in a new layer
RUN cargo build --release
RUN rm src/*.rs
COPY services/identity . COPY services/identity .
COPY shared/protos/identity_client.proto ../../shared/protos/
COPY shared/comm-opaque2 ../../shared/comm-opaque2
RUN cargo install --locked --path . RUN cargo install --locked --path .
FROM debian:bullseye-slim FROM debian:bullseye-slim
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
ca-certificates \ ca-certificates \
&& rm -rf /var/lib/apt/lists/* \ && rm -rf /var/lib/apt/lists/* \
Show All 10 Lines
View Options

web/sidebar/app-switcher.react.js

FROM rust:1.67 as builder FROM rust:1.67 as builder
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
build-essential cmake git libgtest-dev libssl-dev zlib1g-dev \ build-essential cmake git libgtest-dev libssl-dev zlib1g-dev \
&& rm -rf /var/lib/apt/lists/* \ && rm -rf /var/lib/apt/lists/* \
&& mkdir -p /home/root/app/ && mkdir -p /home/root/app/
WORKDIR /home/root/app WORKDIR /home/root/app
# Install more recent version of protobuf, must be ran as root # Install more recent version of protobuf, must be ran as root
COPY scripts/install_protobuf.sh ../../scripts/install_protobuf.sh COPY scripts/install_protobuf.sh ../../scripts/install_protobuf.sh
RUN ../../scripts/install_protobuf.sh RUN ../../scripts/install_protobuf.sh
RUN mkdir -p /home/comm/app/identity RUN mkdir -p /home/comm/app/identity
WORKDIR /home/comm/app/identity WORKDIR /home/comm/app/identity
RUN cargo init --bin
COPY services/identity/Cargo.toml services/identity/Cargo.lock ./
COPY shared/ ../../shared/
# Cache build dependencies in a new layer
RUN cargo build --release
RUN rm src/*.rs
COPY services/identity . COPY services/identity .
COPY shared/protos/identity_client.proto ../../shared/protos/
COPY shared/comm-opaque2 ../../shared/comm-opaque2
RUN cargo install --locked --path . RUN cargo install --locked --path .
FROM debian:bullseye-slim FROM debian:bullseye-slim
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
ca-certificates \ ca-certificates \
&& rm -rf /var/lib/apt/lists/* \ && rm -rf /var/lib/apt/lists/* \
Show All 10 Lines
View Options

web/sidebar/left-layout-aside.css

FROM rust:1.67 as builder FROM rust:1.67 as builder
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
build-essential cmake git libgtest-dev libssl-dev zlib1g-dev \ build-essential cmake git libgtest-dev libssl-dev zlib1g-dev \
&& rm -rf /var/lib/apt/lists/* \ && rm -rf /var/lib/apt/lists/* \
&& mkdir -p /home/root/app/ && mkdir -p /home/root/app/
WORKDIR /home/root/app WORKDIR /home/root/app
# Install more recent version of protobuf, must be ran as root # Install more recent version of protobuf, must be ran as root
COPY scripts/install_protobuf.sh ../../scripts/install_protobuf.sh COPY scripts/install_protobuf.sh ../../scripts/install_protobuf.sh
RUN ../../scripts/install_protobuf.sh RUN ../../scripts/install_protobuf.sh
RUN mkdir -p /home/comm/app/identity RUN mkdir -p /home/comm/app/identity
WORKDIR /home/comm/app/identity WORKDIR /home/comm/app/identity
RUN cargo init --bin
COPY services/identity/Cargo.toml services/identity/Cargo.lock ./
COPY shared/ ../../shared/
# Cache build dependencies in a new layer
RUN cargo build --release
RUN rm src/*.rs
COPY services/identity . COPY services/identity .
COPY shared/protos/identity_client.proto ../../shared/protos/
COPY shared/comm-opaque2 ../../shared/comm-opaque2
RUN cargo install --locked --path . RUN cargo install --locked --path .
FROM debian:bullseye-slim FROM debian:bullseye-slim
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
ca-certificates \ ca-certificates \
&& rm -rf /var/lib/apt/lists/* \ && rm -rf /var/lib/apt/lists/* \
Show All 10 Lines
View Options

web/sidebar/navigation-panel.react.js

FROM rust:1.67 as builder FROM rust:1.67 as builder
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
build-essential cmake git libgtest-dev libssl-dev zlib1g-dev \ build-essential cmake git libgtest-dev libssl-dev zlib1g-dev \
&& rm -rf /var/lib/apt/lists/* \ && rm -rf /var/lib/apt/lists/* \
&& mkdir -p /home/root/app/ && mkdir -p /home/root/app/
WORKDIR /home/root/app WORKDIR /home/root/app
# Install more recent version of protobuf, must be ran as root # Install more recent version of protobuf, must be ran as root
COPY scripts/install_protobuf.sh ../../scripts/install_protobuf.sh COPY scripts/install_protobuf.sh ../../scripts/install_protobuf.sh
RUN ../../scripts/install_protobuf.sh RUN ../../scripts/install_protobuf.sh
RUN mkdir -p /home/comm/app/identity RUN mkdir -p /home/comm/app/identity
WORKDIR /home/comm/app/identity WORKDIR /home/comm/app/identity
RUN cargo init --bin
COPY services/identity/Cargo.toml services/identity/Cargo.lock ./
COPY shared/ ../../shared/
# Cache build dependencies in a new layer
RUN cargo build --release
RUN rm src/*.rs
COPY services/identity . COPY services/identity .
COPY shared/protos/identity_client.proto ../../shared/protos/
COPY shared/comm-opaque2 ../../shared/comm-opaque2
RUN cargo install --locked --path . RUN cargo install --locked --path .
FROM debian:bullseye-slim FROM debian:bullseye-slim
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
ca-certificates \ ca-certificates \
&& rm -rf /var/lib/apt/lists/* \ && rm -rf /var/lib/apt/lists/* \
Show All 10 Lines
View Options

web/sidebar/settings-switcher.react.js

Loading...
View Options

web/topbar/app-switcher.react.js

Loading...
View Options

web/topbar/navigation-panel.react.js

Loading...
View Options

web/topbar/settings-switcher.react.js

Loading...
View Options

web/topbar/topbar.css

Loading...