Paths

Table of Contentst

Differential D6337

[web] Move topbar related code out of web/sidebar
AbandonedPublic
Actions

Authored by inka on Jan 22 2023, 11:22 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 4, 2:23 PM

	Unknown Object (File)
	Mon, Oct 28, 8:11 AM

	Unknown Object (File)
	Tue, Oct 22, 4:00 PM

	Unknown Object (File)
	Sep 28 2024, 1:03 PM

	Unknown Object (File)
	Sep 28 2024, 1:01 PM

	Unknown Object (File)
	Sep 28 2024, 12:53 PM

	Unknown Object (File)
	Aug 27 2024, 9:27 PM

	Unknown Object (File)
	Jul 31 2024, 4:14 AM

View All 41 Files

Subscribers

Details

Reviewers

bartek
• przemek
michal

Summary

Since D6335 the AppSwitcher, SettingsSwitcher and NavigationPanel are no longer in a sidebar, but in a topbar. So the code related to them had to be moved outside of web/sidebar. Moreover since D6336 the LeftLayoutAside doesn't exist
anymore, so the left-layout-aside.css file had been renamed to topbar.css.

Test Plan

Run the web app, check that the topbar displayes correctly.

Diff Detail

Repository

Branch

inka/community_drawer_web

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Jan 22 2023, 11:22 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 22 2023, 11:22 AM

inka added a parent revision: D6336: [web] Remove LeftLayoutAside.Jan 22 2023, 11:23 AM

inka added reviewers: bartek, • przemek, michal.

Harbormaster completed remote builds in B15523: Diff 21172.Jan 22 2023, 11:34 AM

inka requested review of this revision.Jan 22 2023, 11:34 AM

inka planned changes to this revision.Jan 23 2023, 5:58 AM

With my new approach, this has been handled differently

Revision Contents
Changeset List

Path

Size

web/

4 lines

sidebar/

app-switcher.react.js

left-layout-aside.css

navigation-panel.react.js

settings-switcher.react.js

	topbar/
	sidebar/

app-switcher.react.js

2 lines

navigation-panel.react.js

2 lines

settings-switcher.react.js

2 lines

	topbar.css
	left-layout-aside.css

58 lines

Diff 21172

web/app.react.js

Loading...

web/sidebar/app-switcher.react.js

Loading...

web/sidebar/left-layout-aside.css

Loading...

web/sidebar/navigation-panel.react.js

Loading...

web/sidebar/settings-switcher.react.js

Loading...

web/topbar/app-switcher.react.js

Loading...

web/topbar/navigation-panel.react.js

Loading...

web/topbar/settings-switcher.react.js

Loading...

web/topbar/topbar.css

Loading...