Page MenuHomePhabricator

[web] Create a dummy topbar component

Authored by inka on Jan 23 2023, 8:32 AM.
Referenced Files
Unknown Object (File)
Fri, Feb 24, 10:45 PM
Unknown Object (File)
Fri, Feb 24, 7:14 PM
Unknown Object (File)
Thu, Feb 23, 6:53 PM
Unknown Object (File)
Feb 17 2023, 9:33 PM
Unknown Object (File)
Feb 9 2023, 8:43 AM
Unknown Object (File)
Feb 5 2023, 5:04 PM
Unknown Object (File)
Feb 5 2023, 2:43 AM
Unknown Object (File)
Feb 4 2023, 12:44 PM



Adding a Topbar component that will contain the AppSwitcher and the navigation info bar. It will be displayed in the Inbox tab.
For now it displays "dummy", because adding it's contents requires a lot of changes to the code. So in the interest of keeping the diff small it has a dummy content for now.

Test Plan

Displayed it in the App component.

Diff Detail

rCOMM Comm
Lint Not Applicable
Tests Not Applicable

Event Timeline

inka requested review of this revision.Jan 23 2023, 8:47 AM
9 ↗(On Diff #21196)

Always use $ReadOnly if possible!

Remove returning null from Topbar, when in settings tab. I changed the approach, and now it is handled by the parent. This provides a better separation of responsibilities

11–13 ↗(On Diff #21240)

This component will display the AppSwitcher, that will mostly stay the same. It'll change on it's own when user changes selected apps based on selectors.

11–13 ↗(On Diff #21240)

like LeftLayoutAside used to be. It displayed the AppSwitcher before. It was a very similar component to what this will be

This revision is now accepted and ready to land.Jan 24 2023, 2:10 AM