Paths

Table of Contentst

Differential D6344

[web] Remove navigation panel from LeftLayoutAside
ClosedPublic
Actions

Authored by inka on Jan 23 2023, 8:52 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Oct 28, 6:55 AM

	Unknown Object (File)
	Sun, Oct 20, 7:03 AM

	Unknown Object (File)
	Oct 8 2024, 1:18 PM

	Unknown Object (File)
	Sep 28 2024, 12:28 PM

	Unknown Object (File)
	Sep 28 2024, 12:27 PM

	Unknown Object (File)
	Sep 28 2024, 12:27 PM

	Unknown Object (File)
	Sep 28 2024, 12:27 PM

	Unknown Object (File)
	Sep 28 2024, 12:27 PM

View All 81 Files

Subscribers

Details

Reviewers

• przemek
michal
bartek

Commits

rCOMM533fe692aaac: [web] Remove navigation panel from LeftLayoutAside

Summary

issue: https://linear.app/comm/issue/ENG-2739/move-navigationpanel-from-the-sidebar-to-a-top-bar
The AppSwitcher will be in a top bar, and SettingsSwitcher has to be moved to main content, because of how we use the grid.
So For now I'm removing them from the LeftLayoutAside.

Test Plan

Run web app, check that in inbox and settinngs tabs the switchers are not present

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Jan 23 2023, 8:52 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 23 2023, 8:52 AM

inka added a parent revision: D6343: [web] Add possibility for the navigation-panel to be horizontal.Jan 23 2023, 8:59 AM

inka added a child revision: D6345: [web] Use app switcher in the topbar.

Harbormaster completed remote builds in B15539: Diff 21199.Jan 23 2023, 9:07 AM

inka requested review of this revision.Jan 23 2023, 9:07 AM

inka edited the summary of this revision. (Show Details)Jan 24 2023, 12:35 AM

inka mentioned this in D6336: [web] Remove LeftLayoutAside.Jan 24 2023, 12:41 AM

bartek accepted this revision.Jan 26 2023, 5:32 AM

This revision is now accepted and ready to land.Jan 26 2023, 5:32 AM

Rebase

Harbormaster failed remote builds in B16410: Diff 22447!Feb 13 2023, 7:29 AM

Rebase

Harbormaster completed remote builds in B16488: Diff 22535.Feb 14 2023, 3:16 AM

Closed by commit rCOMM533fe692aaac: [web] Remove navigation panel from LeftLayoutAside (authored by • InkaSokolowska). · Explain WhyFeb 14 2023, 5:02 AM

This revision was automatically updated to reflect the committed changes.

• InkaSokolowska added a commit: rCOMM533fe692aaac: [web] Remove navigation panel from LeftLayoutAside.

• InkaSokolowska mentioned this in rCOMM392d1c189563: [web] Remove LeftLayoutAside.

Revision Contents
Changeset List

Path

Size

web/

sidebar/

left-layout-aside.css

3 lines

left-layout-aside.react.js

11 lines

2 lines

Diff 22575

web/sidebar/left-layout-aside.css

Loading...

web/sidebar/left-layout-aside.react.js

Loading...

web/style.css

Loading...