Page MenuHomePhabricator

[web] Move code around to match the new code logic

Authored by inka on Jan 24 2023, 2:17 AM.
Referenced Files
Unknown Object (File)
Sat, Mar 4, 3:23 AM
Unknown Object (File)
Tue, Feb 28, 1:19 PM
Unknown Object (File)
Tue, Feb 28, 3:39 AM
Unknown Object (File)
Fri, Feb 24, 8:25 AM
Unknown Object (File)
Feb 17 2023, 6:12 AM
Unknown Object (File)
Feb 14 2023, 5:41 AM
Unknown Object (File)
Feb 5 2023, 8:09 PM
Unknown Object (File)
Feb 1 2023, 2:14 AM



Now that the SettingSwitcher is no longer in the sidebar, it's code had to be moved outside of web/sidebar. The styles in left-layout-aside.css were only used for SettingsSwticher (and horizontal NavigationPanel that is used only in SettingsSwitcher so the file could be renamed and also moved. NavigationPanel is used for SettingSwitcher and AppSwitcher, so only for navigation panels. Thus all of this code could be put into web/navigation-panels as well as the Topbar, that is a navigation panel (contains AppSwitcher and will contain the navigation state information).

Test Plan

Run web app, check that the top bar in Inbox, and the SettingSwitcher in Settings display correctly. Run flow check in web/.

Diff Detail

rCOMM Comm
Lint Not Applicable
Tests Not Applicable

Event Timeline

inka requested review of this revision.Jan 24 2023, 2:31 AM
This revision is now accepted and ready to land.Feb 9 2023, 5:43 AM