Page MenuHomePhabricator
Feed Advanced Search

Feb 8 2023

przemek closed D6557: [web] Hide typeahead if multiple characters are selected.
Feb 8 2023, 5:51 AM
przemek committed rCOMM28423a51b376: [web] Hide typeahead if multiple characters are selected (authored by przemek).
[web] Hide typeahead if multiple characters are selected
Feb 8 2023, 5:51 AM
przemek added inline comments to D6643: [11/n] Native Typeahead - SelectableTextInput for iOS.
Feb 8 2023, 5:36 AM
przemek added inline comments to D6642: [10/n] Native Typeahead - SelectableTextInput for Android.
Feb 8 2023, 5:35 AM
przemek added inline comments to D6557: [web] Hide typeahead if multiple characters are selected.
Feb 8 2023, 4:35 AM
przemek updated the diff for D6557: [web] Hide typeahead if multiple characters are selected.

Deleted comment as it was redundant.

Feb 8 2023, 4:34 AM

Feb 3 2023

przemek added a comment to D6367: [5/n] Native Typeahead - Add selection state to chat input bar.

On another note. I think @tomek has a day off today.

Feb 3 2023, 5:51 AM
przemek requested review of D6558: Added web tests to .lintstagedrc and CI.
Feb 3 2023, 5:37 AM
przemek requested review of D6557: [web] Hide typeahead if multiple characters are selected.
Feb 3 2023, 5:20 AM
przemek updated the diff for D6367: [5/n] Native Typeahead - Add selection state to chat input bar.

Deleted unnecessary props.

Feb 3 2023, 2:44 AM

Feb 2 2023

przemek updated the diff for D6390: [8/n] Native Typeahead - Create tooltip component in chat input bar.

rebase

Feb 2 2023, 8:04 AM
przemek added inline comments to D6368: [6/n] Native Typeahead - Refactor focusAndUpdateText and add focusAndUpdateTextAndSelection.
Feb 2 2023, 8:02 AM
przemek updated the diff for D6368: [6/n] Native Typeahead - Refactor focusAndUpdateText and add focusAndUpdateTextAndSelection.

Small fix. Rebase and moved comment around.

Feb 2 2023, 7:42 AM
przemek updated the diff for D6367: [5/n] Native Typeahead - Add selection state to chat input bar.

Small fix. Did something wrong while rebasing and comment was not updated.

Feb 2 2023, 7:37 AM
przemek planned changes to D6390: [8/n] Native Typeahead - Create tooltip component in chat input bar.
Feb 2 2023, 7:34 AM
przemek updated the diff for D6390: [8/n] Native Typeahead - Create tooltip component in chat input bar.

Moved the logic to separate function. It's places in lib, as it should also be used in web. We have task for that: https://linear.app/comm/issue/ENG-2891/refactor-some-of-the-native-typeahead-creation-logic-and-make-web
I've tested a lot and it works we default to using state, if values in class fields are null.

Feb 2 2023, 7:24 AM
przemek planned changes to D6390: [8/n] Native Typeahead - Create tooltip component in chat input bar.
Feb 2 2023, 7:23 AM
przemek planned changes to D6368: [6/n] Native Typeahead - Refactor focusAndUpdateText and add focusAndUpdateTextAndSelection.
Feb 2 2023, 7:23 AM
przemek planned changes to D6367: [5/n] Native Typeahead - Add selection state to chat input bar.
Feb 2 2023, 7:23 AM
przemek updated the diff for D6368: [6/n] Native Typeahead - Refactor focusAndUpdateText and add focusAndUpdateTextAndSelection.

Fixing and responding to reviewer

Feb 2 2023, 7:23 AM
przemek updated the diff for D6367: [5/n] Native Typeahead - Add selection state to chat input bar.

I've tried out a lot of solutions. Process and thoughts documented here: https://linear.app/comm/issue/ENG-2890/issue-with-typeahead-flickering-while-the-user-types

Feb 2 2023, 7:21 AM
przemek updated the diff for D6368: [6/n] Native Typeahead - Refactor focusAndUpdateText and add focusAndUpdateTextAndSelection.

Sorry for that, something hasn't refreshed properly apparently.
We need controlSelection set to true in first setter as that's what Android uses.
Tested on iOS and it doesn't affect behaviour.

Feb 2 2023, 3:14 AM
przemek updated the diff for D6368: [6/n] Native Typeahead - Refactor focusAndUpdateText and add focusAndUpdateTextAndSelection.

Fixed comment.
Also changed control selection to false in first setState.
Previously it was set to true, but it didn't affect app behaviour really.
This way it matches comment.

Feb 2 2023, 2:23 AM
przemek closed D6491: Modify native/.flowconfig, so it includes android specific js files..
Feb 2 2023, 2:10 AM
przemek committed rCOMM1b92c5767dee: Modify native/.flowconfig, so it includes android specific js files. (authored by przemek).
Modify native/.flowconfig, so it includes android specific js files.
Feb 2 2023, 2:10 AM

Feb 1 2023

przemek added inline comments to D6390: [8/n] Native Typeahead - Create tooltip component in chat input bar.
Feb 1 2023, 7:12 AM
przemek requested review of D6491: Modify native/.flowconfig, so it includes android specific js files..
Feb 1 2023, 4:52 AM
przemek updated the diff for D6390: [8/n] Native Typeahead - Create tooltip component in chat input bar.

if -> if else.
Rebase.

Feb 1 2023, 3:45 AM
przemek updated the diff for D6368: [6/n] Native Typeahead - Refactor focusAndUpdateText and add focusAndUpdateTextAndSelection.

Going with sleep(100), waiting for animation flash was unreliable and undeterministic.

Feb 1 2023, 3:19 AM
przemek updated the diff for D6390: [8/n] Native Typeahead - Create tooltip component in chat input bar.

Combined conditionals. That logic should be refactoed into seperate functions as it's quire similar to the web counterpart anyway. I've created the task for that: https://linear.app/comm/issue/ENG-2891/refactor-some-of-the-native-typeahead-creation-logic-and-make-web
I'd rather do it after native typeahead is landed as it has higher prio.

Feb 1 2023, 1:42 AM

Jan 31 2023

przemek added inline comments to D6368: [6/n] Native Typeahead - Refactor focusAndUpdateText and add focusAndUpdateTextAndSelection.
Jan 31 2023, 10:06 AM
przemek updated the diff for D6390: [8/n] Native Typeahead - Create tooltip component in chat input bar.

Mostly refactor. Respond to reviewers.

Jan 31 2023, 10:05 AM
przemek updated the diff for D6368: [6/n] Native Typeahead - Refactor focusAndUpdateText and add focusAndUpdateTextAndSelection.

Responding to review and introducing hack allowing us for correct selection after typeahead is clicked.

Jan 31 2023, 10:03 AM
przemek added inline comments to D6367: [5/n] Native Typeahead - Add selection state to chat input bar.
Jan 31 2023, 9:42 AM
przemek updated the diff for D6367: [5/n] Native Typeahead - Add selection state to chat input bar.

Huge changes here. Explantions in code comments as the solutions are terribly hacky.

Jan 31 2023, 9:42 AM
przemek updated the diff for D6390: [8/n] Native Typeahead - Create tooltip component in chat input bar.

small fix - the condition was wrong

Jan 31 2023, 4:33 AM
przemek planned changes to D6390: [8/n] Native Typeahead - Create tooltip component in chat input bar.
Jan 31 2023, 3:30 AM
przemek added inline comments to D6390: [8/n] Native Typeahead - Create tooltip component in chat input bar.
Jan 31 2023, 2:52 AM
przemek updated the diff for D6390: [8/n] Native Typeahead - Create tooltip component in chat input bar.

I've tested the app in simulator, which is not ideal, but probably less time consuming than dealign with physcial build right now, and the performance seems identical using master branch, or branch with typeahead feature. I've pasted huge message into chat input bar, and hasn't spotted any lag when it comes to typeahead showing or updating.

Jan 31 2023, 2:52 AM

Jan 29 2023

przemek updated the diff for D6390: [8/n] Native Typeahead - Create tooltip component in chat input bar.

Small fix

Jan 29 2023, 2:37 PM
przemek added inline comments to D6369: [7/n] Native Typeahead - Introduce tooltip component.
Jan 29 2023, 2:37 PM
przemek updated the diff for D6369: [7/n] Native Typeahead - Introduce tooltip component.

Responding to review.

Jan 29 2023, 2:35 PM

Jan 27 2023

przemek requested review of D6415: [4.5/n] Native Typeahead - Refactoring to the common utility function.
Jan 27 2023, 6:38 AM

Jan 26 2023

przemek updated the diff for D6369: [7/n] Native Typeahead - Introduce tooltip component.

Fixed typos and revised text.

Jan 26 2023, 11:38 PM
przemek updated the diff for D6369: [7/n] Native Typeahead - Introduce tooltip component.

Updated comment. I feel like now it's really exhaustive explantion of both the bug and fix.
Or at least as exhaustive as comment can get.

Jan 26 2023, 8:13 AM
przemek accepted D6164: [web] Add community drawer to CommunityPicker.
Jan 26 2023, 6:17 AM
przemek added inline comments to D6162: [web] Add community drawer.
Jan 26 2023, 5:01 AM
przemek added inline comments to D6160: [web] Add drawer item implementations.
Jan 26 2023, 4:37 AM
przemek accepted D6159: [web] Add subchannels button.
Jan 26 2023, 3:40 AM
przemek added a comment to D6159: [web] Add subchannels button.

Looks great apart from text color concern

Jan 26 2023, 3:40 AM
przemek requested review of D6393: Fixed incorret display for long thread names on web..
Jan 26 2023, 3:11 AM
przemek updated the diff for D6369: [7/n] Native Typeahead - Introduce tooltip component.

Added comment justifying GestureHandler

Jan 26 2023, 12:19 AM

Jan 25 2023

przemek requested review of D6390: [8/n] Native Typeahead - Create tooltip component in chat input bar.
Jan 25 2023, 7:43 AM
przemek requested review of D6367: [5/n] Native Typeahead - Add selection state to chat input bar.
Jan 25 2023, 7:37 AM
przemek requested review of D6368: [6/n] Native Typeahead - Refactor focusAndUpdateText and add focusAndUpdateTextAndSelection.
Jan 25 2023, 7:29 AM
przemek updated the diff for D6369: [7/n] Native Typeahead - Introduce tooltip component.

Cleaned up and added PanGestureHandler so the component still takes pan/scroll events even ig it's not scrollable

Jan 25 2023, 7:26 AM

Jan 24 2023

przemek planned changes to D6368: [6/n] Native Typeahead - Refactor focusAndUpdateText and add focusAndUpdateTextAndSelection.
Jan 24 2023, 2:32 PM
przemek planned changes to D6369: [7/n] Native Typeahead - Introduce tooltip component.
Jan 24 2023, 1:43 PM
przemek requested review of D6369: [7/n] Native Typeahead - Introduce tooltip component.
Jan 24 2023, 1:35 PM
przemek requested review of D6368: [6/n] Native Typeahead - Refactor focusAndUpdateText and add focusAndUpdateTextAndSelection.
Jan 24 2023, 1:27 PM
przemek updated the diff for D6298: [2/n] Native Typeahead - Adding utility file and native regex.

Added comment

Jan 24 2023, 12:29 PM

Jan 20 2023

przemek requested review of D6298: [2/n] Native Typeahead - Adding utility file and native regex.
Jan 20 2023, 5:39 AM
przemek requested review of D6299: [3/n] Native Typeahead - Change max height of textarea.
Jan 20 2023, 5:29 AM
przemek requested review of D6300: [4/n] Native Typeahead - Add user search and thread members to props.
Jan 20 2023, 5:29 AM

Jan 19 2023

przemek requested review of D6297: [1/n] Native Typeahead - Moving type decalration to lib.
Jan 19 2023, 6:38 AM

Jan 13 2023

przemek closed D6182: [web] Empty password caused "Unknown error" during login.
Jan 13 2023, 7:39 AM
przemek committed rCOMM520eeeaba4cb: [web] Empty password caused "Unknown error" during login (authored by przemek).
[web] Empty password caused "Unknown error" during login
Jan 13 2023, 7:39 AM
przemek added a comment to D6052: [web] Keyboard support for typeahead [12/13] - Scrolling thourgh overlay as user interacts with it.

No, I'll do it right now

Jan 13 2023, 2:15 AM

Jan 12 2023

przemek closed D6052: [web] Keyboard support for typeahead [12/13] - Scrolling thourgh overlay as user interacts with it.
Jan 12 2023, 6:21 AM
przemek closed D6051: [web] Keyboard support for typeahead [11/13] - Use callbacks to interact with overlay.
Jan 12 2023, 6:21 AM
przemek closed D6053: [web] Keyboard support for typeahead [13/13] - Freeze users list when typeahead is visible..
Jan 12 2023, 6:21 AM
przemek committed rCOMMfb601172deb0: [web] Keyboard support for typeahead [12/13] - Scrolling thourgh overlay as… (authored by przemek).
[web] Keyboard support for typeahead [12/13] - Scrolling thourgh overlay as…
Jan 12 2023, 6:21 AM
przemek committed rCOMM651e6f9a655c: [web] Keyboard support for typeahead [11/13] - Use callbacks to interact with… (authored by przemek).
[web] Keyboard support for typeahead [11/13] - Use callbacks to interact with…
Jan 12 2023, 6:21 AM
przemek committed rCOMM4227160aa188: [web] Keyboard support for typeahead [13/13] - Freeze users list when typeahead… (authored by przemek).
[web] Keyboard support for typeahead [13/13] - Freeze users list when typeahead…
Jan 12 2023, 6:21 AM
przemek closed D6050: [web] Keyboard support for typeahead [10/13] - Create and set callback functions in tooltip component. It does not do anything yet.
Jan 12 2023, 6:21 AM
przemek closed D6048: [web] Keyboard support for typeahead [8/13] - Add positive modulo function.
Jan 12 2023, 6:21 AM
przemek closed D6049: [web] Keyboard support for typeahead [9/13] - Refactor getTypeaheadTooltipButtons as a function.
Jan 12 2023, 6:21 AM
przemek committed rCOMMa0d9fb26b1e1: [web] Keyboard support for typeahead [10/13] - Create and set callback… (authored by przemek).
[web] Keyboard support for typeahead [10/13] - Create and set callback…
Jan 12 2023, 6:21 AM
przemek committed rCOMM84aef4c58dca: [web] Keyboard support for typeahead [9/13] - Refactor… (authored by przemek).
[web] Keyboard support for typeahead [9/13] - Refactor…
Jan 12 2023, 6:21 AM
przemek committed rCOMM2241ebe29a11: [web] Keyboard support for typeahead [8/13] - Add positive modulo function (authored by przemek).
[web] Keyboard support for typeahead [8/13] - Add positive modulo function
Jan 12 2023, 6:21 AM
przemek closed D6047: [web] Keyboard support for typeahead [7/13] - Refactor getTypeaheadTooltipActions using params as argument.
Jan 12 2023, 6:21 AM
przemek closed D6046: [web] Keyboard support for typeahead [6/13] - Get rid of entire text and rename matched strings.
Jan 12 2023, 6:21 AM
przemek closed D6045: [web] Keyboard support for typeahead [5/13] - Moved finding suggested users out of tooltip component.
Jan 12 2023, 6:21 AM
przemek committed rCOMM743b663b08cd: [web] Keyboard support for typeahead [7/13] - Refactor… (authored by przemek).
[web] Keyboard support for typeahead [7/13] - Refactor…
Jan 12 2023, 6:21 AM
przemek committed rCOMM6994060d445e: [web] Keyboard support for typeahead [6/13] - Get rid of entire text and rename… (authored by przemek).
[web] Keyboard support for typeahead [6/13] - Get rid of entire text and rename…
Jan 12 2023, 6:21 AM
przemek committed rCOMMd7f2decc2753: [web] Keyboard support for typeahead [5/13] - Moved finding suggested users out… (authored by przemek).
[web] Keyboard support for typeahead [5/13] - Moved finding suggested users out…
Jan 12 2023, 6:21 AM
przemek closed D6043: [web] Keyboard support for typeahead [3/13] - Renamed animation state.
Jan 12 2023, 6:21 AM
przemek closed D6044: [web] Keyboard support for typeahead [4/13] - Renamed regex.
Jan 12 2023, 6:21 AM
przemek committed rCOMM22a1c541b219: [web] Keyboard support for typeahead [4/13] - Renamed regex (authored by przemek).
[web] Keyboard support for typeahead [4/13] - Renamed regex
Jan 12 2023, 6:21 AM
przemek committed rCOMMa8237a96fcbc: [web] Keyboard support for typeahead [3/13] - Renamed animation state (authored by przemek).
[web] Keyboard support for typeahead [3/13] - Renamed animation state
Jan 12 2023, 6:21 AM
przemek closed D6042: [web] Keyboard support for typeahead [2/13] - Moved typeahead-utils.js.
Jan 12 2023, 6:21 AM
przemek committed rCOMM9c267823c49b: [web] Keyboard support for typeahead [2/13] - Moved typeahead-utils.js (authored by przemek).
[web] Keyboard support for typeahead [2/13] - Moved typeahead-utils.js
Jan 12 2023, 6:21 AM
przemek closed D6041: [web] Keyboard support for typeahead [1/13] - Moved getTypeaheadUserSuggestions to lib.
Jan 12 2023, 6:18 AM
przemek committed rCOMM15354950eecb: [web] Keyboard support for typeahead [1/13] - Moved getTypeaheadUserSuggestions… (authored by przemek).
[web] Keyboard support for typeahead [1/13] - Moved getTypeaheadUserSuggestions…
Jan 12 2023, 6:18 AM
przemek updated the diff for D6041: [web] Keyboard support for typeahead [1/13] - Moved getTypeaheadUserSuggestions to lib.

rebase

Jan 12 2023, 1:54 AM
przemek closed D5819: [web] Add other <button> props to Button..
Jan 12 2023, 1:47 AM
przemek committed rCOMM37d992b39e38: [web] Add other <button> props to Button. (authored by przemek).
[web] Add other <button> props to Button.
Jan 12 2023, 1:47 AM
przemek closed D5818: [web] Additional state required for keyboard support for typeahead..
Jan 12 2023, 1:47 AM
przemek committed rCOMM4dd39e37978b: [web] Additional state required for keyboard support for typeahead. (authored by przemek).
[web] Additional state required for keyboard support for typeahead.
Jan 12 2023, 1:47 AM
przemek added inline comments to D6159: [web] Add subchannels button.
Jan 12 2023, 1:32 AM