Page MenuHomePhabricator
Differential D6300

[4/n] Native Typeahead - Add user search and thread members to props
ClosedPublic
Actions

Authored by • przemek on Jan 18 2023, 8:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 1:34 AM
Unknown Object (File)
Mon, Nov 11, 11:54 PM
Unknown Object (File)
Fri, Nov 8, 10:11 AM
Unknown Object (File)
Tue, Nov 5, 7:01 PM
Unknown Object (File)
Mon, Nov 4, 1:41 AM
Unknown Object (File)
Tue, Oct 29, 6:54 AM
Unknown Object (File)
Tue, Oct 29, 6:54 AM
Unknown Object (File)
Tue, Oct 29, 6:54 AM
View All Files
Subscribers
ashoat
atul
ginsu
inka
kamil
michal
tomek

Details

Reviewers
inka
ginsu
kamil
michal
tomek
Commits
rCOMM077ada547375: [4/n] Native Typeahead - Add user search and thread members to props
Summary

Preparing for native typeahead.
We will need threadMembers and searchIndex to find suggested users based on what current user typed in input bar.

Test Plan

Checked if app builds.
Will use those props in later diffs.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• przemek created this revision.Jan 18 2023, 8:57 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 18 2023, 8:57 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 18 2023, 9:00 AM
Harbormaster failed remote builds in B15439: Diff 21048!
Harbormaster completed remote builds in B15439: Diff 21048.Jan 20 2023, 5:29 AM
• przemek requested review of this revision.Jan 20 2023, 5:29 AM
inka accepted this revision.Jan 24 2023, 4:13 AM
This revision is now accepted and ready to land.Jan 24 2023, 4:13 AM
• przemek added a parent revision: D6299: [3/n] Native Typeahead - Change max height of textarea.Jan 24 2023, 1:07 PM
• przemek added a child revision: D6367: [5/n] Native Typeahead - Add selection state to chat input bar.
• przemek added a child revision: D6415: [4.5/n] Native Typeahead - Refactoring to the common utility function.Jan 27 2023, 6:37 AM
• przemek removed a child revision: D6367: [5/n] Native Typeahead - Add selection state to chat input bar.
tomek accepted this revision.Jan 30 2023, 2:48 AM
ashoat updated this revision to Diff 22208.Feb 7 2023, 9:10 AM

Rebase

Harbormaster completed remote builds in B16237: Diff 22208.Feb 7 2023, 9:29 AM
Closed by commit rCOMM077ada547375: [4/n] Native Typeahead - Add user search and thread members to props (authored by • przemek, committed by ashoat). · Explain WhyFeb 7 2023, 2:37 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM077ada547375: [4/n] Native Typeahead - Add user search and thread members to props.

Revision Contents
Changeset List

PathSize
native/
chat/
15 lines

Diff 22245

View Options

native/chat/chat-input-bar.react.js

Loading...