Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 17, 6:40 AM

	Unknown Object (File)
	Wed, Apr 17, 6:40 AM

	Unknown Object (File)
	Wed, Apr 17, 6:40 AM

	Unknown Object (File)
	Wed, Apr 17, 6:39 AM

	Unknown Object (File)
	Wed, Apr 17, 6:37 AM

	Unknown Object (File)
	Mar 12 2024, 11:20 PM

	Unknown Object (File)
	Feb 22 2024, 11:41 PM

	Unknown Object (File)
	Feb 22 2024, 9:22 PM

Subscribers

Details

Reviewers

inka
ginsu
kamil
michal
tomek

Commits

rCOMM9eb5b3df2c1f: [1/n] Native Typeahead - Moving type decalration to lib

Summary

We can use the same type both in web and native logic.
Thus moving it to shared typeahead utils.

Test Plan

Checked if web app still works

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• przemek created this revision.Jan 18 2023, 8:47 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 18 2023, 8:47 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 18 2023, 8:50 AM

Harbormaster failed remote builds in B15436: Diff 21045!

Harbormaster completed remote builds in B15436: Diff 21045.Jan 19 2023, 6:38 AM

• przemek requested review of this revision.Jan 19 2023, 6:38 AM

inka accepted this revision.Jan 20 2023, 3:54 AM

This revision is now accepted and ready to land.Jan 20 2023, 3:54 AM

• przemek added a child revision: D6298: [2/n] Native Typeahead - Adding utility file and native regex.Jan 24 2023, 1:07 PM

tomek accepted this revision.Jan 30 2023, 1:54 AM

Rebase

Harbormaster completed remote builds in B16234: Diff 22205.Feb 7 2023, 9:23 AM

Closed by commit rCOMM9eb5b3df2c1f: [1/n] Native Typeahead - Moving type decalration to lib (authored by • przemek, committed by ashoat). · Explain WhyFeb 7 2023, 2:37 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM9eb5b3df2c1f: [1/n] Native Typeahead - Moving type decalration to lib.

[1/n] Native Typeahead - Moving type decalration to lib
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 22242

lib/shared/typeahead-utils.js

web/chat/chat-input-bar.react.js

web/chat/typeahead-tooltip.react.js

[1/n] Native Typeahead - Moving type decalration to libClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 22242

lib/shared/typeahead-utils.js

web/chat/chat-input-bar.react.js

web/chat/typeahead-tooltip.react.js

[1/n] Native Typeahead - Moving type decalration to lib
ClosedPublic
Actions

Revision Contents
Changeset List