Page MenuHomePhabricator
Differential D6297

[1/n] Native Typeahead - Moving type decalration to lib
ClosedPublic
Actions

Authored by • przemek on Jan 18 2023, 8:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 3, 5:01 AM
Unknown Object (File)
Tue, Apr 1, 9:45 AM
Unknown Object (File)
Mar 7 2025, 7:31 PM
Unknown Object (File)
Mar 7 2025, 7:31 PM
Unknown Object (File)
Mar 7 2025, 7:31 PM
Unknown Object (File)
Mar 7 2025, 7:31 PM
Unknown Object (File)
Mar 7 2025, 7:25 PM
Unknown Object (File)
Mar 3 2025, 2:26 PM
View All Files
Subscribers
ashoat
atul
ginsu
inka
kamil
michal
tomek

Details

Reviewers
inka
ginsu
kamil
michal
tomek
Commits
rCOMM9eb5b3df2c1f: [1/n] Native Typeahead - Moving type decalration to lib
Summary

We can use the same type both in web and native logic.
Thus moving it to shared typeahead utils.

Test Plan

Checked if web app still works

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• przemek created this revision.Jan 18 2023, 8:47 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 18 2023, 8:47 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 18 2023, 8:50 AM
Harbormaster failed remote builds in B15436: Diff 21045!
Harbormaster completed remote builds in B15436: Diff 21045.Jan 19 2023, 6:38 AM
• przemek requested review of this revision.Jan 19 2023, 6:38 AM
inka accepted this revision.Jan 20 2023, 3:54 AM
This revision is now accepted and ready to land.Jan 20 2023, 3:54 AM
• przemek added a child revision: D6298: [2/n] Native Typeahead - Adding utility file and native regex.Jan 24 2023, 1:07 PM
tomek accepted this revision.Jan 30 2023, 1:54 AM
ashoat updated this revision to Diff 22205.Feb 7 2023, 9:09 AM

Rebase

Harbormaster completed remote builds in B16234: Diff 22205.Feb 7 2023, 9:23 AM
Closed by commit rCOMM9eb5b3df2c1f: [1/n] Native Typeahead - Moving type decalration to lib (authored by • przemek, committed by ashoat). · Explain WhyFeb 7 2023, 2:37 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM9eb5b3df2c1f: [1/n] Native Typeahead - Moving type decalration to lib.

Revision Contents
Changeset List

PathSize
lib/
shared/
5 lines
web/
chat/
6 lines
2 lines

Diff 22242

View Options

lib/shared/typeahead-utils.js

Show All 21 Lines
a { a {
text-decoration: none; text-decoration: none;
color: #2a5db0; color: #2a5db0;
} }
img, img,
iframe { iframe {
display: block; display: block;
} }
input[type='text'], input[type='text'],
input[type='password'], input[type='password'],
textarea { textarea {
atulUnsubmitted
Not Done
Inline Actions

Moving the global input styling and moving it to the input component.

Then why are we keeping styles like border and border-radius?

Don't these styles also affect the <textarea> tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for input and another for textarea)?

atul: > Moving the global input styling and moving it to the input component. Then why are we…
benschacAuthorUnsubmitted
Done
Inline Actions

Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect textarea elements.

benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
-webkit-appearance: none;
-moz-appearance: none;
-webkit-border-radius: 0;
border: 1px solid #dddddd; border: 1px solid #dddddd;
border-radius: 1px; border-radius: 1px;
font-family: var(--font-stack); font-family: var(--font-stack);
} }
:global(#react-root) { :global(#react-root) {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
height: 100%; height: 100%;
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines
View Options

web/chat/chat-input-bar.react.js

Show All 21 Lines
a { a {
text-decoration: none; text-decoration: none;
color: #2a5db0; color: #2a5db0;
} }
img, img,
iframe { iframe {
display: block; display: block;
} }
input[type='text'], input[type='text'],
input[type='password'], input[type='password'],
textarea { textarea {
atulUnsubmitted
Not Done
Inline Actions

Moving the global input styling and moving it to the input component.

Then why are we keeping styles like border and border-radius?

Don't these styles also affect the <textarea> tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for input and another for textarea)?

atul: > Moving the global input styling and moving it to the input component. Then why are we…
benschacAuthorUnsubmitted
Done
Inline Actions

Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect textarea elements.

benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
-webkit-appearance: none;
-moz-appearance: none;
-webkit-border-radius: 0;
border: 1px solid #dddddd; border: 1px solid #dddddd;
border-radius: 1px; border-radius: 1px;
font-family: var(--font-stack); font-family: var(--font-stack);
} }
:global(#react-root) { :global(#react-root) {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
height: 100%; height: 100%;
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines
View Options

web/chat/typeahead-tooltip.react.js

Show All 21 Lines
a { a {
text-decoration: none; text-decoration: none;
color: #2a5db0; color: #2a5db0;
} }
img, img,
iframe { iframe {
display: block; display: block;
} }
input[type='text'], input[type='text'],
input[type='password'], input[type='password'],
textarea { textarea {
atulUnsubmitted
Not Done
Inline Actions

Moving the global input styling and moving it to the input component.

Then why are we keeping styles like border and border-radius?

Don't these styles also affect the <textarea> tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for input and another for textarea)?

atul: > Moving the global input styling and moving it to the input component. Then why are we…
benschacAuthorUnsubmitted
Done
Inline Actions

Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect textarea elements.

benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
-webkit-appearance: none;
-moz-appearance: none;
-webkit-border-radius: 0;
border: 1px solid #dddddd; border: 1px solid #dddddd;
border-radius: 1px; border-radius: 1px;
font-family: var(--font-stack); font-family: var(--font-stack);
} }
:global(#react-root) { :global(#react-root) {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
height: 100%; height: 100%;
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines