Differential D6299

[3/n] Native Typeahead - Change max height of textarea
ClosedPublic
Actions

Authored by • przemek on Jan 18 2023, 8:54 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 17, 6:40 AM

	Unknown Object (File)
	Wed, Apr 17, 6:40 AM

	Unknown Object (File)
	Wed, Apr 17, 6:40 AM

	Unknown Object (File)
	Wed, Apr 17, 6:39 AM

	Unknown Object (File)
	Wed, Apr 17, 6:36 AM

	Unknown Object (File)
	Mar 12 2024, 11:21 PM

	Unknown Object (File)
	Mar 12 2024, 11:21 PM

	Unknown Object (File)
	Feb 26 2024, 11:42 PM

View All 42 Files

Subscribers

Details

Reviewers

inka
ginsu
kamil
michal
tomek

Commits

rCOMM993313395be6: [3/n] Native Typeahead - Change max height of textarea

Summary

As mentioned here: https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC?node-id=4097:55267#330566637
We want to reduce height of text input.
That's what I did

Test Plan

Images on:

Android:

{F334601}

iOS

{F334602}

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• przemek created this revision.Jan 18 2023, 8:54 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 18 2023, 8:54 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 18 2023, 8:57 AM

Harbormaster failed remote builds in B15438: Diff 21047!

• przemek edited the test plan for this revision. (Show Details)Jan 19 2023, 6:36 AM

Harbormaster completed remote builds in B15438: Diff 21047.Jan 20 2023, 5:29 AM

• przemek requested review of this revision.Jan 20 2023, 5:29 AM

inka accepted this revision.Jan 24 2023, 2:55 AM

This revision is now accepted and ready to land.Jan 24 2023, 2:55 AM

• przemek added a parent revision: D6298: [2/n] Native Typeahead - Adding utility file and native regex.Jan 24 2023, 1:07 PM

• przemek added a child revision: D6300: [4/n] Native Typeahead - Add user search and thread members to props.

The images from test plan don't show for me. The solution is described here: https://www.notion.so/commapp/Attaching-files-and-images-on-Phabricator-af8e2195fc91462689cc8de5c96a6759

Rebase

Harbormaster completed remote builds in B16236: Diff 22207.Feb 7 2023, 9:27 AM

Closed by commit rCOMM993313395be6: [3/n] Native Typeahead - Change max height of textarea (authored by • przemek, committed by ashoat). · Explain WhyFeb 7 2023, 2:37 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM993313395be6: [3/n] Native Typeahead - Change max height of textarea.

Revision Contents
Changeset List

Path

Size

native/

chat/

chat-input-bar.react.js

2 lines

Diff 22244

native/chat/chat-input-bar.react.js

Loading...