Renamed state that is used for animations only, so it's not confused with anything that might have to do with logic of displaying overlay.
Details
Details
Typeahead without keyboard support works.
Final tests performed in last diffs.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Accepting with questions
| web/chat/typeahead-tooltip.react.js | ||
|---|---|---|
| 46 ↗ | (On Diff #20154) | Is there a reason why we didn't add setIsVisibleForAnimation to the list of dependencies? |
| web/chat/typeahead-tooltip.react.js | ||
|---|---|---|
| 46 ↗ | (On Diff #20154) | You don't need to. In general you can trust the ESLint rule to make sure the dep list is right. In the case of setIsVisibleForAnimation, useState setters are constant through the lifetime of a component |
| web/chat/typeahead-tooltip.react.js | ||
|---|---|---|
| 46 ↗ | (On Diff #20154) | Gotcha thanks for clairfying, I patched locally and wasn't getting an error so figured everything was copacetic |