Page MenuHomePhabricator
Differential D6049

[web] Keyboard support for typeahead [9/13] - Refactor getTypeaheadTooltipButtons as a function
ClosedPublic
Actions

Authored by • przemek on Dec 27 2022, 4:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 9:22 AM
Unknown Object (File)
Mon, Mar 17, 9:22 AM
Unknown Object (File)
Mon, Mar 17, 9:21 AM
Unknown Object (File)
Mon, Mar 17, 9:13 AM
Unknown Object (File)
Feb 20 2025, 10:30 AM
Unknown Object (File)
Feb 13 2025, 3:57 PM
Unknown Object (File)
Feb 13 2025, 3:57 PM
Unknown Object (File)
Feb 13 2025, 3:56 PM
View All Files
Subscribers
ashoat
atul
ginsu
inka
kamil
tomek

Details

Reviewers
inka
kamil
ginsu
tomek
Commits
rCOMM84aef4c58dca: [web] Keyboard support for typeahead [9/13] - Refactor…
Summary

Moved creating buttons in overlay to utility function.

Test Plan

Typeahead without keyboard support works.
Final tests performed in last diffs.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• przemek created this revision.Dec 27 2022, 4:57 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptDec 27 2022, 4:57 AM
Harbormaster completed remote builds in B14783: Diff 20162.Dec 27 2022, 5:11 AM
• przemek requested review of this revision.Dec 27 2022, 5:11 AM
• przemek added a parent revision: D6048: [web] Keyboard support for typeahead [8/13] - Add positive modulo function.Dec 27 2022, 5:31 AM
• przemek added a child revision: D6050: [web] Keyboard support for typeahead [10/13] - Create and set callback functions in tooltip component. It does not do anything yet.
inka accepted this revision.Dec 28 2022, 7:08 AM
inka added a reviewer: tomek.
tomek accepted this revision.Dec 30 2022, 9:19 AM

Why do you move it?

This revision is now accepted and ready to land.Dec 30 2022, 9:19 AM
• przemek added a comment.Jan 5 2023, 1:22 AM

It felt cleaner to has it closed in utils funtion.

Closed by commit rCOMM84aef4c58dca: [web] Keyboard support for typeahead [9/13] - Refactor… (authored by • przemek). · Explain WhyJan 12 2023, 6:21 AM
This revision was automatically updated to reflect the committed changes.
• przemek added a commit: rCOMM84aef4c58dca: [web] Keyboard support for typeahead [9/13] - Refactor….

Revision Contents
Changeset List

PathSize
web/
chat/
13 lines
utils/
13 lines

Diff 20867

View Options

web/chat/typeahead-tooltip.react.js

#pragma once #pragma once
#include "AwsTools.h" #include "AwsTools.h"
#include "Constants.h" #include "Constants.h"
#include "DatabaseEntitiesTools.h" #include "DatabaseEntitiesTools.h"
#include "Tools.h" #include "Tools.h"
#include <aws/core/Aws.h> #include <aws/core/Aws.h>
#include <aws/core/utils/Outcome.h> #include <aws/core/utils/Outcome.h>
#include <aws/dynamodb/model/AttributeDefinition.h> #include <aws/dynamodb/model/AttributeDefinition.h>
#include <aws/dynamodb/model/DeleteItemRequest.h> #include <aws/dynamodb/model/DeleteItemRequest.h>
#include <aws/dynamodb/model/DescribeTableRequest.h> #include <aws/dynamodb/model/DescribeTableRequest.h>
#include <aws/dynamodb/model/DescribeTableResult.h> #include <aws/dynamodb/model/DescribeTableResult.h>
#include <aws/dynamodb/model/GetItemRequest.h> #include <aws/dynamodb/model/GetItemRequest.h>
#include <aws/dynamodb/model/PutItemRequest.h> #include <aws/dynamodb/model/PutItemRequest.h>
#include <aws/dynamodb/model/QueryRequest.h>
#include <memory> #include <memory>
#include <string> #include <string>
namespace comm { namespace comm {
namespace network { namespace network {
namespace database { namespace database {
Show All 22 Linespublic:
void removeSessionSignItem(const std::string &deviceID); void removeSessionSignItem(const std::string &deviceID);
void putPublicKeyItem(const PublicKeyItem &item); void putPublicKeyItem(const PublicKeyItem &item);
std::shared_ptr<PublicKeyItem> findPublicKeyItem(const std::string &deviceID); std::shared_ptr<PublicKeyItem> findPublicKeyItem(const std::string &deviceID);
void removePublicKeyItem(const std::string &deviceID); void removePublicKeyItem(const std::string &deviceID);
void putMessageItem(const MessageItem &item); void putMessageItem(const MessageItem &item);
std::shared_ptr<MessageItem> findMessageItem(const std::string &messageID); std::shared_ptr<MessageItem> findMessageItem(const std::string &messageID);
std::vector<std::shared_ptr<MessageItem>>
findMessageItemsByReceiver(const std::string &toDeviceID);
void removeMessageItem(const std::string &messageID); void removeMessageItem(const std::string &messageID);
}; };
} // namespace database } // namespace database
} // namespace network } // namespace network
} // namespace comm } // namespace comm
View Options

web/utils/typeahead-utils.js

#pragma once #pragma once
#include "AwsTools.h" #include "AwsTools.h"
#include "Constants.h" #include "Constants.h"
#include "DatabaseEntitiesTools.h" #include "DatabaseEntitiesTools.h"
#include "Tools.h" #include "Tools.h"
#include <aws/core/Aws.h> #include <aws/core/Aws.h>
#include <aws/core/utils/Outcome.h> #include <aws/core/utils/Outcome.h>
#include <aws/dynamodb/model/AttributeDefinition.h> #include <aws/dynamodb/model/AttributeDefinition.h>
#include <aws/dynamodb/model/DeleteItemRequest.h> #include <aws/dynamodb/model/DeleteItemRequest.h>
#include <aws/dynamodb/model/DescribeTableRequest.h> #include <aws/dynamodb/model/DescribeTableRequest.h>
#include <aws/dynamodb/model/DescribeTableResult.h> #include <aws/dynamodb/model/DescribeTableResult.h>
#include <aws/dynamodb/model/GetItemRequest.h> #include <aws/dynamodb/model/GetItemRequest.h>
#include <aws/dynamodb/model/PutItemRequest.h> #include <aws/dynamodb/model/PutItemRequest.h>
#include <aws/dynamodb/model/QueryRequest.h>
#include <memory> #include <memory>
#include <string> #include <string>
namespace comm { namespace comm {
namespace network { namespace network {
namespace database { namespace database {
Show All 22 Linespublic:
void removeSessionSignItem(const std::string &deviceID); void removeSessionSignItem(const std::string &deviceID);
void putPublicKeyItem(const PublicKeyItem &item); void putPublicKeyItem(const PublicKeyItem &item);
std::shared_ptr<PublicKeyItem> findPublicKeyItem(const std::string &deviceID); std::shared_ptr<PublicKeyItem> findPublicKeyItem(const std::string &deviceID);
void removePublicKeyItem(const std::string &deviceID); void removePublicKeyItem(const std::string &deviceID);
void putMessageItem(const MessageItem &item); void putMessageItem(const MessageItem &item);
std::shared_ptr<MessageItem> findMessageItem(const std::string &messageID); std::shared_ptr<MessageItem> findMessageItem(const std::string &messageID);
std::vector<std::shared_ptr<MessageItem>>
findMessageItemsByReceiver(const std::string &toDeviceID);
void removeMessageItem(const std::string &messageID); void removeMessageItem(const std::string &messageID);
}; };
} // namespace database } // namespace database
} // namespace network } // namespace network
} // namespace comm } // namespace comm