Paths

Table of Contentst

-
web/
-
chat/
-
chat-input-bar.react.js
-
utils/
-
typeahead-utils.js

[web] Keyboard support for typeahead [4/13] - Renamed regex
ClosedPublic
Actions

Authored by • przemek on Dec 27 2022, 4:39 AM.

Details

Reviewers

inka
kamil
ginsu
tomek

Commits

rCOMM22a1c541b219: [web] Keyboard support for typeahead [4/13] - Renamed regex

Summary

Renamed regex. It might be redundant, as it is placed in web directory, but it doesn't hurt.
Native typeahead will be placed in native dir and named accordingly.

Test Plan

Typeahead without keyboard support works.
Final tests performed in last diffs.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• przemek created this revision.Dec 27 2022, 4:39 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptDec 27 2022, 4:39 AM

Harbormaster completed remote builds in B14777: Diff 20155.Dec 27 2022, 4:52 AM

• przemek requested review of this revision.Dec 27 2022, 4:52 AM

• przemek added a parent revision: D6043: [web] Keyboard support for typeahead [3/13] - Renamed animation state.Dec 27 2022, 5:30 AM

• przemek added a child revision: D6045: [web] Keyboard support for typeahead [5/13] - Moved finding suggested users out of tooltip component.

ginsu accepted this revision.Dec 27 2022, 3:53 PM

This revision is now accepted and ready to land.Dec 27 2022, 3:53 PM

• przemek added a reviewer: tomek.Dec 29 2022, 11:56 AM

This revision now requires review to proceed.Dec 29 2022, 11:56 AM

tomek accepted this revision.Dec 30 2022, 8:29 AM

This revision is now accepted and ready to land.Dec 30 2022, 8:29 AM

Closed by commit rCOMM22a1c541b219: [web] Keyboard support for typeahead [4/13] - Renamed regex (authored by • przemek). · Explain WhyJan 12 2023, 6:21 AM

This revision was automatically updated to reflect the committed changes.

• przemek added a commit: rCOMM22a1c541b219: [web] Keyboard support for typeahead [4/13] - Renamed regex.

Revision Contents
Changeset List

Path

Size

web/

chat/

chat-input-bar.react.js

5 lines

utils/

typeahead-utils.js

4 lines

Diff 20862

View Options

web/chat/chat-input-bar.react.js