HomePhabricator
Diffusion Comm 139c314bd1ce

[native] [web] Use `tinycolor` when comparing colors represented as strings

Description

[native] [web] Use tinycolor when comparing colors represented as strings

Summary: Recently have run into some bugs with checking color equality between two hex strings (using the basic === operator). Changed this equality (or inequality) check to use tinycolor.equals() instead throughout the codebase.

Test Plan: Tested LoadingIndicator and ThreadSettings on web and ensured that they looked as expected after the change.

Reviewers: atul

Reviewed By: atul

Subscribers: ashoat, palys-swm, Adrian

Differential Revision: https://phab.comm.dev/D4243

Details

Provenance
aboshAuthored on Jun 9 2022, 2:18 PM
Reviewer
atul
Differential Revision
D4243: [native] [web] Use `tinycolor` when comparing colors represented as strings
Parents
rCOMMfc9bd07a7c3e: [CI] Bump GitHub Actions Ubuntu machines to `ubuntu-latest`
Branches
Loading...
Tags
Loading...