[native] [web] Use `tinycolor` when comparing colors represented as strings
ClosedPublic
Actions

Authored by • abosh on Jun 9 2022, 2:29 PM.

Details

Reviewers

atul

Commits

rCOMM139c314bd1ce: [native] [web] Use `tinycolor` when comparing colors represented as strings

Summary

Recently have run into some bugs with checking color equality between two hex strings (using the basic === operator). Changed this equality (or inequality) check to use tinycolor.equals() instead throughout the codebase.

Test Plan

Tested LoadingIndicator and ThreadSettings on web and ensured that they looked as expected after the change.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• abosh created this revision.Jun 9 2022, 2:29 PM

Herald added subscribers: • adrian, tomek, ashoat. · View Herald TranscriptJun 9 2022, 2:29 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 9 2022, 2:30 PM

Harbormaster failed remote builds in B9704: Diff 13445!

• abosh edited the summary of this revision. (Show Details)Jun 9 2022, 2:30 PM

• abosh edited the test plan for this revision. (Show Details)

• abosh added 1 blocking reviewer(s): atul.

Harbormaster completed remote builds in B9704: Diff 13445.Jun 10 2022, 4:19 PM

• abosh requested review of this revision.Jun 10 2022, 4:19 PM

• abosh added inline comments.Jun 10 2022, 5:07 PM

web/calendar/entry.react.js
198 ↗	(On Diff #13445)	This change is just a minor style fix that corrects the prior string concatenation to use `${}` placeholder syntax (used throughout the codebase).