HomePhabricator
Diffusion Comm 14a2d48ffc5e

[native] fix forcing the incorrect height for text messages

Description

[native] fix forcing the incorrect height for text messages

Summary:
This diff is part 2/3 to fix forcing the incorrect height for messages with inline engagement in prod.

This linear comment explains this issue and what I did to address this

Since item.contentHeight is now the height of the inner text message AND the height of the inline engagement we are now forcing the wrong height for the inner text message component. An idea I want to explore to address this is to force the height higher up in the component tree (somewhere like ComposedMessage) where both the "inner message" and the inline engagement is rendered so that when we force the height withitem.contentHeight, it is correct

Depends on D8797

Test Plan:
Please see demo video where I force and unforce the correct height of the text message and it did not change visually (outside of the green background) and I did not get any error logs talking about incorrect height measurements, I also purposely force an incorrect height (which resulted in some logs about incorrect height measurements.

Also please note for the video, I set a green background so that it is easier to visually see what is happening, but these are only for the demo videos

With the correct height measurement:

With the incorrect height measurement:

Reviewers: atul, kamil, tomek, ashoat

Reviewed By: ashoat

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D8798

Details

Provenance
ginsuAuthored on Aug 11 2023, 2:23 PM
Reviewer
ashoat
Differential Revision
D8798: [native] fix forcing the incorrect height for text messages
Parents
rCOMM1a2ed5620f18: [native] fix forcing the incorrect height for robotext messages
Branches
Unknown
Tags
Unknown