HomePhabricator
Diffusion Comm 190b098d2697

[CommCoreModule] MessageSpec changes for updated `UPDATE_RELATIONSHIP`

Description

[CommCoreModule] MessageSpec changes for updated UPDATE_RELATIONSHIP

Summary:
This is effectively https://github.com/CommE2E/comm/commit/3d47f80c594a69206179fd8f33bb57d31b1fd78d and https://github.com/CommE2E/comm/commit/f1debdb595bcba76db8e91ff8d70519b9b0a785b squashed together into a single diff.

We use the same spec for both on the C++ side.


Depends on D11382

Test Plan:
Close reading + builds

NOTE: It appears that we're missing a spec for TOGGLE_PIN. This doesn't appear to cause any issues on C++ side since message_specs_initializer is a Map rather than eg std::vector so it's fine that we have a "gap."

Reviewers: ashoat, ginsu, varun, will

Reviewed By: ashoat

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D11383

Details

Provenance
atulAuthored on Mar 28 2024, 5:58 AM
Reviewer
ashoat
Differential Revision
D11383: [CommCoreModule] MessageSpec changes for updated `UPDATE_RELATIONSHIP`
Parents
rCOMM652a137d6429: [lib][native] FIDProvider
Branches
Unknown
Tags
Unknown