HomePhabricator
Diffusion Comm 1a5147283e7a

[web] Fix tabs in modals displaying incorrectly

Tags
None
Referenced Files
F390947: image.png
Feb 22 2023, 10:08 AM
File Not Attached
F390910: image.png
Feb 22 2023, 10:08 AM
File Not Attached
F390907: image.png
Feb 22 2023, 10:08 AM
File Not Attached
F390946: image.png
Feb 22 2023, 10:08 AM
File Not Attached
F390945: image.png
Feb 22 2023, 10:08 AM
File Not Attached
F390904: image.png
Feb 22 2023, 10:08 AM
File Not Attached
F390903: image.png
Feb 22 2023, 10:08 AM
File Not Attached
Subscribers
None

Description

[web] Fix tabs in modals displaying incorrectly

Summary:
issue: https://linear.app/comm/issue/ENG-3049/fix-tabs-header-container
In D6734 I missed the fact that Tabs was also used in some modals. This made them display incorrectly - not like in our designs. This diff fixes that by applying different styles based on a
flag passed as a prop. I dodn't create a separate component, because they would differ in only two lines. Instead, I change the css they use, like we do in NavigationPanel.

Before fix:

image.png (268×740 px, 16 KB)

image.png (390×816 px, 24 KB)

After fix:

image.png (262×738 px, 20 KB)

image.png (412×792 px, 26 KB)

And the tabs in chat still styled according to the new designs:
image.png (352×738 px, 31 KB)

Here are the tabs on commit d6865be7150cb1e2c63bfd64faf03c34af842163, before my changes that introduces the bug (they look the same):

image.png (252×746 px, 20 KB)

image.png (420×808 px, 30 KB)

Test Plan: Run we app, checked that tabs in modals display as they used to, and tabs in Chat display according to the new designs

Reviewers: tomek, michal, kamil, bartek

Reviewed By: tomek, bartek

Subscribers: ashoat, atul

Differential Revision: https://phab.comm.dev/D6782

Details

Provenance
InkaSokolowskaAuthored on Feb 22 2023, 8:46 AM
Reviewer
tomek
Differential Revision
D6782: [web] Fix tabs in modals displaying incorrectly
Parents
rCOMM2b5cc9dbafc0: [web] Change "Sign in" button colors to match designs
Branches
Unknown
Tags
Unknown