Page MenuHomePhabricator

[web] Restyle Focus / Background buttons
ClosedPublic

Authored by inka on Feb 14 2023, 6:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 28, 6:54 PM
Unknown Object (File)
Tue, Feb 27, 10:21 PM
Unknown Object (File)
Tue, Feb 27, 10:21 PM
Unknown Object (File)
Tue, Feb 27, 10:21 PM
Unknown Object (File)
Tue, Feb 27, 10:21 PM
Unknown Object (File)
Tue, Feb 27, 10:21 PM
Unknown Object (File)
Tue, Feb 27, 10:16 PM
Unknown Object (File)
Sun, Feb 25, 8:24 PM
Subscribers

Details

Summary

issue: https://linear.app/comm/issue/ENG-2791/restyle-focus-background-buttons
The icons were supposed to be dropped, and "Focus" was supposed to change to "Focused". Additionally some styles were changed.

Test Plan

Run web app, checked that buttons display correctly and work as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka requested review of this revision.Feb 14 2023, 7:02 AM

Looks great!
(I know there is an example in linear, but I would love a screenshot/video in the summary)

web/components/tabs.css
23 ↗(On Diff #22597)

probably subtle transition of the background color will be great (suggested also by Atul)

This revision is now accepted and ready to land.Feb 15 2023, 2:19 AM