Page MenuHomePhabricator
Differential D6734

[web] Restyle Focus / Background buttons
ClosedPublic
Actions

Authored by inka on Feb 14 2023, 6:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 28, 9:22 PM
Unknown Object (File)
Mon, Oct 28, 9:22 PM
Unknown Object (File)
Mon, Oct 28, 9:22 PM
Unknown Object (File)
Mon, Oct 28, 9:22 PM
Unknown Object (File)
Mon, Oct 28, 9:22 PM
Unknown Object (File)
Mon, Oct 28, 9:19 PM
Unknown Object (File)
Oct 12 2024, 2:46 AM
Unknown Object (File)
Oct 10 2024, 3:39 AM
View All 100 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
michal
• kuba
kamil
Commits
rCOMM93be68e015c1: [web] Restyle Focus / Background buttons
Summary

issue: https://linear.app/comm/issue/ENG-2791/restyle-focus-background-buttons
The icons were supposed to be dropped, and "Focus" was supposed to change to "Focused". Additionally some styles were changed.

Test Plan

Run web app, checked that buttons display correctly and work as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Feb 14 2023, 6:44 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptFeb 14 2023, 6:44 AM
inka updated this revision to Diff 22597.Feb 14 2023, 6:47 AM

Fix colour

Harbormaster completed remote builds in B16516: Diff 22596.Feb 14 2023, 6:57 AM
Harbormaster completed remote builds in B16517: Diff 22597.Feb 14 2023, 7:02 AM
inka requested review of this revision.Feb 14 2023, 7:02 AM
kamil accepted this revision.Feb 15 2023, 2:19 AM

Looks great!
(I know there is an example in linear, but I would love a screenshot/video in the summary)

web/components/tabs.css
23 ↗(On Diff #22597)

probably subtle transition of the background color will be great (suggested also by Atul)

This revision is now accepted and ready to land.Feb 15 2023, 2:19 AM
inka edited the summary of this revision. (Show Details)Feb 16 2023, 1:27 AM
inka updated this revision to Diff 22645.Feb 16 2023, 1:28 AM

Add transition to hover

Harbormaster completed remote builds in B16549: Diff 22645.Feb 16 2023, 1:43 AM
inka attached a referenced file: F382537: Screen Recording 2023-02-15 at 11.57.52.mov. (Show Details)Feb 17 2023, 1:00 AM
Closed by commit rCOMM93be68e015c1: [web] Restyle Focus / Background buttons (authored by • InkaSokolowska). · Explain WhyFeb 17 2023, 1:08 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMM93be68e015c1: [web] Restyle Focus / Background buttons.
inka mentioned this in D6782: [web] Fix tabs in modals displaying incorrectly.Feb 20 2023, 6:45 AM
• InkaSokolowska mentioned this in rCOMM1a5147283e7a: [web] Fix tabs in modals displaying incorrectly.Feb 22 2023, 10:08 AM

Revision Contents
Changeset List

PathSize
web/
chat/
7 lines
14 lines
components/
26 lines
4 lines
3 lines

Diff 22665

View Options

web/chat/chat-tabs.react.js

Loading...
View Options

web/chat/chat-thread-tab.react.js

Loading...
View Options

web/components/tabs.css

Loading...
View Options

web/components/tabs.react.js

Loading...
View Options

web/theme.css

Loading...