HomePhabricator
Diffusion Comm 1cebf0c85915

[native] [6/40] RN 0.70: Update Android NDK to 24 for M1 hosts

Description

[native] [6/40] RN 0.70: Update Android NDK to 24 for M1 hosts

Summary:
The React Native update had this change, but I initially had to disable the newer NDK in D5898 because of issues with compiling our old version of Folly. After D5899 updated us to a recent Folly, I tried NDK 24 again and encountered two other bugs.

The first was a glog build error. I found that the file that was failing to be compiled could be avoided based on a condition here, which seemed to be connected with a CMake flag.

The second was a Cargo build failure from an #include <atomic> line in the produced cxx.cc file. This GitHub comment pointed me at the solution, which was to use a different Cargo target.

I'm not really sure how to test the armeabi-v7a target beyond confirming that the build succeeds, but I should make sure to test the arm64-v8a target on the device at the office. The armeabi-v7a target is the only one where the Cargo target change matters, unfortunately...

Depends on D5899

Test Plan: Tested along with whole stack: test plan

Reviewers: tomek, bartek, jon!, varun!

Subscribers: atul

Differential Revision: https://phab.comm.dev/D5900

Details

Provenance
ashoatAuthored on Nov 12 2022, 8:11 AM
Differential Revision
D5900: [native] [6/40] RN 0.70: Update Android NDK to 24 for M1 hosts
Parents
rCOMMd09a531fa436: [native] [5/40] RN 0.70: Update Folly on Android
Branches
Unknown
Tags
Unknown