Page MenuHomePhabricator

[native] [4/40] RN 0.70: Android stuff
ClosedPublic

Authored by ashoat on Dec 17 2022, 7:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 4:48 PM
Unknown Object (File)
Thu, Nov 14, 9:58 AM
Unknown Object (File)
Wed, Nov 13, 10:51 PM
Unknown Object (File)
Sun, Nov 10, 5:54 PM
Unknown Object (File)
Fri, Nov 8, 8:17 AM
Unknown Object (File)
Fri, Nov 8, 5:47 AM
Unknown Object (File)
Fri, Nov 8, 3:27 AM
Unknown Object (File)
Fri, Nov 8, 3:08 AM
Subscribers

Details

Summary

These are the Android changes from React Native Upgrade Helper. Exceptions to that are highlighted inline.

Depends on D5897

Test Plan

Tested along with whole stack: test plan

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 17 2022, 7:32 PM
Harbormaster failed remote builds in B14227: Diff 19461!
native/android/app/CMakeLists.txt
145 ↗(On Diff #19461)

This file was moved so we need to update where we're pointing to

native/android/app/build.gradle
84 ↗(On Diff #19461)

To confirm this was safe to remove, I first set it to some incorrect value to see what the error condition would be. I then confirmed that the error condition did not occur with the default value (eg. after I removed the custom value)

86 ↗(On Diff #19461)

To confirm this was safe to remove, I first set it to some incorrect value to see what the error condition would be. I then confirmed that the error condition did not occur with the default value (eg. after I removed the custom value)

For this one, I also did some code sleuthing to see where this was used, and added a log statement to make sure it was being done correctly

Please ignore CI until the end of the stack

Fix cmake-lint error due to line in new file native/android/app/src/main/jni/CMakeLists.txt

tomek requested changes to this revision.Dec 19 2022, 4:51 AM
tomek added inline comments.
native/android/app/src/main/java/app/comm/android/MainActivity.java
27–30 ↗(On Diff #19515)

Why is this method commented out? In the guide it is present.

This revision now requires changes to proceed.Dec 19 2022, 4:51 AM
native/android/app/src/main/java/app/comm/android/MainActivity.java
27–30 ↗(On Diff #19515)

Oops, good catch. D5935 updates our createReactActivityDelegate to use MainActivityDelegate, but that's the wrong place to do it... and there is still commented-out code even after that change.

I'll fix this up

Actually use MainActivityDelegate

This revision is now accepted and ready to land.Dec 19 2022, 8:19 AM
This revision was landed with ongoing or failed builds.Dec 20 2022, 12:00 PM
This revision was automatically updated to reflect the committed changes.