Page MenuHomePhabricator

[native] [2/40] RN 0.70: Podfile update
ClosedPublic

Authored by ashoat on Dec 17 2022, 7:21 PM.
Tags
None
Referenced Files
F3227674: D5896.id19459.diff
Mon, Nov 11, 11:44 PM
Unknown Object (File)
Mon, Nov 11, 9:44 PM
Unknown Object (File)
Sun, Nov 10, 5:55 PM
Unknown Object (File)
Wed, Nov 6, 7:10 PM
Unknown Object (File)
Wed, Nov 6, 6:25 AM
Unknown Object (File)
Wed, Nov 6, 6:25 AM
Unknown Object (File)
Wed, Nov 6, 6:25 AM
Unknown Object (File)
Mon, Nov 4, 8:23 AM
Subscribers

Details

Summary

Changes mostly pulled from React Native Upgrade Helper. Will describe the rest inline.

Depends on D5895

Test Plan

Along with testing pod install, this was tested along with whole stack: test plan

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

native/ios/Podfile
29 ↗(On Diff #19459)

I had to make this change for the app to work. Not sure why config[:reactNativePath] wasn't working anymore. Can investigate this more if desired

39 ↗(On Diff #19459)

This gets disabled later in the stack, but keeping it the same here for now

47 ↗(On Diff #19459)

I had to make this change for pod install to work

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 17 2022, 7:24 PM
Harbormaster failed remote builds in B14225: Diff 19459!

Please ignore CI until the end of the stack

This revision is now accepted and ready to land.Dec 19 2022, 4:33 AM
This revision was landed with ongoing or failed builds.Dec 20 2022, 12:00 PM
This revision was automatically updated to reflect the committed changes.