Differential D5914

[native] [20/40] RN 0.70: Replace deprecated icons
ClosedPublic
Actions

Authored by ashoat on Dec 18 2022, 7:10 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 14, 3:35 PM

	Unknown Object (File)
	Sat, Dec 14, 3:35 PM

	Unknown Object (File)
	Sat, Dec 14, 3:35 PM

	Unknown Object (File)
	Sat, Dec 14, 3:35 PM

	Unknown Object (File)
	Sat, Dec 14, 3:35 PM

	Unknown Object (File)
	Sat, Dec 14, 3:35 PM

	Unknown Object (File)
	Sat, Dec 14, 3:35 PM

	Unknown Object (File)
	Sat, Dec 14, 3:35 PM

Subscribers

Details

Reviewers

tomek
bartek

Commits

rCOMMf2a5a44c6bf9: [native] [20/40] RN 0.70: Replace deprecated icons

Summary

Flow reported that some icon name were incorrect. I investigated, and sure enough those icon names weren't working. Looks like they were deprecated or something. I replaced them with what I determined was the renamed icons, and in some cases applied small edits to styles to adjust for differences.

Test Plan

Checked out the screens for each of the icons I changed on both iOS and Android

Depends on D5913

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 18 2022, 7:10 PM

Herald added a subscriber: atul. · View Herald TranscriptDec 18 2022, 7:10 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 7:11 PM

Harbormaster failed remote builds in B14243: Diff 19482!

ashoat added a child revision: D5915: [native] [21/40] RN 0.70: Update comm-react-native-codegen.Dec 18 2022, 7:14 PM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:24 PM

Harbormaster failed remote builds in B14265: Diff 19504!

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:56 PM

Harbormaster failed remote builds in B14292: Diff 19531!

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 8:35 AM

Harbormaster failed remote builds in B14344: Diff 19593!

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 9:04 AM

Harbormaster failed remote builds in B14377: Diff 19626!

Please ignore CI until the end of the stack

Rebase

Harbormaster failed remote builds in B14444: Diff 19699!Dec 19 2022, 12:34 PM

bartek accepted this revision.Dec 20 2022, 3:15 AM

This revision is now accepted and ready to land.Dec 20 2022, 3:15 AM

tomek accepted this revision.Dec 20 2022, 5:12 AM

Rebase

Harbormaster failed remote builds in B14500: Diff 19757!Dec 20 2022, 6:28 AM

Rebase

Harbormaster failed remote builds in B14559: Diff 19819!Dec 20 2022, 11:17 AM

This revision was landed with ongoing or failed builds.Dec 20 2022, 12:01 PM

Closed by commit rCOMMf2a5a44c6bf9: [native] [20/40] RN 0.70: Replace deprecated icons (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMf2a5a44c6bf9: [native] [20/40] RN 0.70: Replace deprecated icons.

Revision Contents
Changeset List

Path

Size

native/

chat/

chat-thread-list-see-more-sidebars.react.js

2 lines

message-list-header-title.react.js

8 lines

settings/

thread-settings-list-action.react.js

6 lines

media/

camera-modal.react.js

2 lines

Diff 19860

native/chat/chat-thread-list-see-more-sidebars.react.js

Loading...

native/chat/message-list-header-title.react.js

Loading...

native/chat/settings/thread-settings-list-action.react.js

Loading...

native/media/camera-modal.react.js

Loading...