Page MenuHomePhabricator

[native] [20/40] RN 0.70: Replace deprecated icons
ClosedPublic

Authored by ashoat on Dec 18 2022, 7:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 5:54 PM
Unknown Object (File)
Fri, Nov 8, 10:46 AM
Unknown Object (File)
Mon, Nov 4, 4:06 PM
Unknown Object (File)
Mon, Nov 4, 4:06 PM
Unknown Object (File)
Mon, Nov 4, 4:05 PM
Unknown Object (File)
Mon, Nov 4, 4:05 PM
Unknown Object (File)
Mon, Nov 4, 4:05 PM
Unknown Object (File)
Sun, Nov 3, 2:47 AM
Subscribers

Details

Summary

Flow reported that some icon name were incorrect. I investigated, and sure enough those icon names weren't working. Looks like they were deprecated or something. I replaced them with what I determined was the renamed icons, and in some cases applied small edits to styles to adjust for differences.

Test Plan

Checked out the screens for each of the icons I changed on both iOS and Android

Depends on D5913

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 7:11 PM
Harbormaster failed remote builds in B14243: Diff 19482!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:24 PM
Harbormaster failed remote builds in B14265: Diff 19504!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:56 PM
Harbormaster failed remote builds in B14292: Diff 19531!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 8:35 AM
Harbormaster failed remote builds in B14344: Diff 19593!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 9:04 AM
Harbormaster failed remote builds in B14377: Diff 19626!

Please ignore CI until the end of the stack

This revision is now accepted and ready to land.Dec 20 2022, 3:15 AM
This revision was landed with ongoing or failed builds.Dec 20 2022, 12:01 PM
This revision was automatically updated to reflect the committed changes.