Page MenuHomePhabricator
Differential D5940

[native] [39/40] RN 0.70: Update to @react-native-community/netinfo@9.3.7
ClosedPublic
Actions

Authored by ashoat on Dec 19 2022, 7:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 20, 12:51 PM
Unknown Object (File)
Mon, Mar 17, 4:17 PM
Unknown Object (File)
Sun, Mar 16, 1:56 PM
Unknown Object (File)
Sat, Mar 15, 7:05 AM
Unknown Object (File)
Sat, Mar 8, 6:32 PM
Unknown Object (File)
Sat, Mar 8, 6:32 PM
Unknown Object (File)
Sat, Mar 8, 6:32 PM
Unknown Object (File)
Sat, Mar 8, 6:32 PM
View All Files
Subscribers
atul

Details

Reviewers
tomek
bartek
Commits
rCOMMf911efd73440: [native] [39/40] RN 0.70: Update to @react-native-community/netinfo@9.3.7
Summary

npx @rnx-kit/dep-check --write recommended upgrading this package (albeit to a lower version).

Depends on D5939

Test Plan
  1. I reviewed the Release Notes and found no breaking changes that might affect us
  2. I tested flipping on Airplane Mode on an iOS simulator and made sure that the callback in ConnectivityUpdater got triggered
  3. Tested along with whole stack: test plan (includes testing Airplane Mode)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 19 2022, 7:25 AM
Herald added a subscriber: atul. · View Herald TranscriptDec 19 2022, 7:25 AM
ashoat added a child revision: D5941: [native] [40/40] RN 0.70: Update to react-native-safe-area-context@4.4.1.Dec 19 2022, 7:26 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 7:27 AM
Harbormaster failed remote builds in B14325: Diff 19568!
ashoat updated this revision to Diff 19612.Dec 19 2022, 8:23 AM

Rebase

ashoat updated this revision to Diff 19645.Dec 19 2022, 8:39 AM

Rebase

Harbormaster failed remote builds in B14363: Diff 19612!Dec 19 2022, 8:48 AM
ashoat published this revision for review.Dec 19 2022, 9:14 AM

Please ignore CI until the end of the stack

Harbormaster failed remote builds in B14396: Diff 19645!Dec 19 2022, 9:17 AM
ashoat updated this revision to Diff 19669.Dec 19 2022, 10:02 AM

Rebase

Harbormaster failed remote builds in B14418: Diff 19669!Dec 19 2022, 10:07 AM
ashoat updated this revision to Diff 19680.Dec 19 2022, 10:24 AM

Rebase

Harbormaster failed remote builds in B14428: Diff 19680!Dec 19 2022, 11:22 AM
ashoat updated this revision to Diff 19718.Dec 19 2022, 12:31 PM

Rebase

Harbormaster failed remote builds in B14463: Diff 19718!Dec 19 2022, 1:01 PM
ashoat updated this revision to Diff 19742.Dec 19 2022, 3:37 PM

Rebase

Harbormaster completed remote builds in B14486: Diff 19742.Dec 19 2022, 3:54 PM
bartek accepted this revision.Dec 20 2022, 3:49 AM
This revision is now accepted and ready to land.Dec 20 2022, 3:49 AM
ashoat updated this revision to Diff 19776.Dec 20 2022, 6:24 AM

Rebase

Harbormaster completed remote builds in B14519: Diff 19776.Dec 20 2022, 7:02 AM
tomek accepted this revision.Dec 20 2022, 9:07 AM
ashoat updated this revision to Diff 19838.Dec 20 2022, 11:04 AM

Rebase

Harbormaster completed remote builds in B14578: Diff 19838.Dec 20 2022, 11:54 AM
Closed by commit rCOMMf911efd73440: [native] [39/40] RN 0.70: Update to @react-native-community/netinfo@9.3.7 (authored by ashoat). · Explain WhyDec 20 2022, 12:01 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMf911efd73440: [native] [39/40] RN 0.70: Update to @react-native-community/netinfo@9.3.7.

Revision Contents
Changeset List

PathSize
native/
ios/
4 lines
2 lines
8 lines

Diff 19879

View Options

native/ios/Podfile.lock

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { Text } from 'react-native'; import { Text, View, Image, Linking } from 'react-native';
import RegistrationButtonContainer from './registration-button-container.react.js'; import RegistrationButtonContainer from './registration-button-container.react.js';
import RegistrationButton from './registration-button.react.js'; import RegistrationButton from './registration-button.react.js';
import RegistrationContainer from './registration-container.react.js'; import RegistrationContainer from './registration-container.react.js';
import RegistrationContentContainer from './registration-content-container.react.js'; import RegistrationContentContainer from './registration-content-container.react.js';
import { RegistrationContext } from './registration-context.js'; import { RegistrationContext } from './registration-context.js';
import type { RegistrationNavigationProp } from './registration-navigator.react.js'; import type { RegistrationNavigationProp } from './registration-navigator.react.js';
import type { import type {
CoolOrNerdMode, CoolOrNerdMode,
AccountSelection, AccountSelection,
AvatarData, AvatarData,
} from './registration-types.js'; } from './registration-types.js';
import commSwooshSource from '../../img/comm-swoosh.png';
import type { NavigationRoute } from '../../navigation/route-names.js'; import type { NavigationRoute } from '../../navigation/route-names.js';
import { useStyles } from '../../themes/colors.js'; import { useStyles } from '../../themes/colors.js';
export type RegistrationTermsParams = { export type RegistrationTermsParams = {
+userSelections: { +userSelections: {
+coolOrNerdMode: CoolOrNerdMode, +coolOrNerdMode: CoolOrNerdMode,
+keyserverUsername: string, +keyserverUsername: string,
+accountSelection: AccountSelection, +accountSelection: AccountSelection,
+avatarData: ?AvatarData, +avatarData: ?AvatarData,
}, },
}; };
const onTermsOfUsePressed = () => {
Linking.openURL('https://comm.app/terms');
};
const onPrivacyPolicyPressed = () => {
Linking.openURL('https://comm.app/privacy');
};
type Props = { type Props = {
+navigation: RegistrationNavigationProp<'RegistrationTerms'>, +navigation: RegistrationNavigationProp<'RegistrationTerms'>,
+route: NavigationRoute<'RegistrationTerms'>, +route: NavigationRoute<'RegistrationTerms'>,
}; };
function RegistrationTerms(props: Props): React.Node { function RegistrationTerms(props: Props): React.Node {
const registrationContext = React.useContext(RegistrationContext); const registrationContext = React.useContext(RegistrationContext);
invariant(registrationContext, 'registrationContext should be set'); invariant(registrationContext, 'registrationContext should be set');
const { register } = registrationContext; const { register } = registrationContext;
const [registrationInProgress, setRegistrationInProgress] = const [registrationInProgress, setRegistrationInProgress] =
React.useState(false); React.useState(false);
const { userSelections } = props.route.params; const { userSelections } = props.route.params;
const onProceed = React.useCallback(async () => { const onProceed = React.useCallback(async () => {
setRegistrationInProgress(true); setRegistrationInProgress(true);
try { try {
await register(userSelections); await register(userSelections);
} finally { } finally {
setRegistrationInProgress(false); setRegistrationInProgress(false);
} }
}, [register, userSelections]); }, [register, userSelections]);
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
/* eslint-disable react-native/no-raw-text */
const termsNotice = (
<Text style={styles.body}>
By registering, you are agreeing to our{' '}
<Text style={styles.hyperlinkText} onPress={onTermsOfUsePressed}>
Terms of Use
</Text>
{' and '}
<Text style={styles.hyperlinkText} onPress={onPrivacyPolicyPressed}>
Privacy Policy
</Text>
.
</Text>
);
/* eslint-enable react-native/no-raw-text */
return ( return (
<RegistrationContainer> <RegistrationContainer>
<RegistrationContentContainer> <RegistrationContentContainer style={styles.scrollViewContentContainer}>
<Text style={styles.header}>Finish registration</Text> <Text style={styles.header}>Finish registration</Text>
{termsNotice}
<View style={styles.commSwooshContainer}>
<Image source={commSwooshSource} style={styles.commSwoosh} />
</View>
</RegistrationContentContainer> </RegistrationContentContainer>
<RegistrationButtonContainer> <RegistrationButtonContainer>
<RegistrationButton <RegistrationButton
onPress={onProceed} onPress={onProceed}
label="Register" label="Register"
variant={registrationInProgress ? 'loading' : 'enabled'} variant={registrationInProgress ? 'loading' : 'enabled'}
/> />
</RegistrationButtonContainer> </RegistrationButtonContainer>
</RegistrationContainer> </RegistrationContainer>
); );
} }
const unboundStyles = { const unboundStyles = {
scrollViewContentContainer: {
flexGrow: 1,
},
header: { header: {
fontSize: 24, fontSize: 24,
color: 'panelForegroundLabel', color: 'panelForegroundLabel',
paddingBottom: 16, paddingBottom: 16,
}, },
body: {
fontFamily: 'Arial',
fontSize: 15,
lineHeight: 20,
color: 'panelForegroundSecondaryLabel',
paddingBottom: 16,
},
commSwooshContainer: {
flexGrow: 1,
flexShrink: 1,
alignItems: 'center',
justifyContent: 'center',
},
commSwoosh: {
resizeMode: 'center',
width: '100%',
height: '100%',
},
hyperlinkText: {
color: 'purpleLink',
},
}; };
export default RegistrationTerms; export default RegistrationTerms;
View Options

native/package.json

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { Text } from 'react-native'; import { Text, View, Image, Linking } from 'react-native';
import RegistrationButtonContainer from './registration-button-container.react.js'; import RegistrationButtonContainer from './registration-button-container.react.js';
import RegistrationButton from './registration-button.react.js'; import RegistrationButton from './registration-button.react.js';
import RegistrationContainer from './registration-container.react.js'; import RegistrationContainer from './registration-container.react.js';
import RegistrationContentContainer from './registration-content-container.react.js'; import RegistrationContentContainer from './registration-content-container.react.js';
import { RegistrationContext } from './registration-context.js'; import { RegistrationContext } from './registration-context.js';
import type { RegistrationNavigationProp } from './registration-navigator.react.js'; import type { RegistrationNavigationProp } from './registration-navigator.react.js';
import type { import type {
CoolOrNerdMode, CoolOrNerdMode,
AccountSelection, AccountSelection,
AvatarData, AvatarData,
} from './registration-types.js'; } from './registration-types.js';
import commSwooshSource from '../../img/comm-swoosh.png';
import type { NavigationRoute } from '../../navigation/route-names.js'; import type { NavigationRoute } from '../../navigation/route-names.js';
import { useStyles } from '../../themes/colors.js'; import { useStyles } from '../../themes/colors.js';
export type RegistrationTermsParams = { export type RegistrationTermsParams = {
+userSelections: { +userSelections: {
+coolOrNerdMode: CoolOrNerdMode, +coolOrNerdMode: CoolOrNerdMode,
+keyserverUsername: string, +keyserverUsername: string,
+accountSelection: AccountSelection, +accountSelection: AccountSelection,
+avatarData: ?AvatarData, +avatarData: ?AvatarData,
}, },
}; };
const onTermsOfUsePressed = () => {
Linking.openURL('https://comm.app/terms');
};
const onPrivacyPolicyPressed = () => {
Linking.openURL('https://comm.app/privacy');
};
type Props = { type Props = {
+navigation: RegistrationNavigationProp<'RegistrationTerms'>, +navigation: RegistrationNavigationProp<'RegistrationTerms'>,
+route: NavigationRoute<'RegistrationTerms'>, +route: NavigationRoute<'RegistrationTerms'>,
}; };
function RegistrationTerms(props: Props): React.Node { function RegistrationTerms(props: Props): React.Node {
const registrationContext = React.useContext(RegistrationContext); const registrationContext = React.useContext(RegistrationContext);
invariant(registrationContext, 'registrationContext should be set'); invariant(registrationContext, 'registrationContext should be set');
const { register } = registrationContext; const { register } = registrationContext;
const [registrationInProgress, setRegistrationInProgress] = const [registrationInProgress, setRegistrationInProgress] =
React.useState(false); React.useState(false);
const { userSelections } = props.route.params; const { userSelections } = props.route.params;
const onProceed = React.useCallback(async () => { const onProceed = React.useCallback(async () => {
setRegistrationInProgress(true); setRegistrationInProgress(true);
try { try {
await register(userSelections); await register(userSelections);
} finally { } finally {
setRegistrationInProgress(false); setRegistrationInProgress(false);
} }
}, [register, userSelections]); }, [register, userSelections]);
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
/* eslint-disable react-native/no-raw-text */
const termsNotice = (
<Text style={styles.body}>
By registering, you are agreeing to our{' '}
<Text style={styles.hyperlinkText} onPress={onTermsOfUsePressed}>
Terms of Use
</Text>
{' and '}
<Text style={styles.hyperlinkText} onPress={onPrivacyPolicyPressed}>
Privacy Policy
</Text>
.
</Text>
);
/* eslint-enable react-native/no-raw-text */
return ( return (
<RegistrationContainer> <RegistrationContainer>
<RegistrationContentContainer> <RegistrationContentContainer style={styles.scrollViewContentContainer}>
<Text style={styles.header}>Finish registration</Text> <Text style={styles.header}>Finish registration</Text>
{termsNotice}
<View style={styles.commSwooshContainer}>
<Image source={commSwooshSource} style={styles.commSwoosh} />
</View>
</RegistrationContentContainer> </RegistrationContentContainer>
<RegistrationButtonContainer> <RegistrationButtonContainer>
<RegistrationButton <RegistrationButton
onPress={onProceed} onPress={onProceed}
label="Register" label="Register"
variant={registrationInProgress ? 'loading' : 'enabled'} variant={registrationInProgress ? 'loading' : 'enabled'}
/> />
</RegistrationButtonContainer> </RegistrationButtonContainer>
</RegistrationContainer> </RegistrationContainer>
); );
} }
const unboundStyles = { const unboundStyles = {
scrollViewContentContainer: {
flexGrow: 1,
},
header: { header: {
fontSize: 24, fontSize: 24,
color: 'panelForegroundLabel', color: 'panelForegroundLabel',
paddingBottom: 16, paddingBottom: 16,
}, },
body: {
fontFamily: 'Arial',
fontSize: 15,
lineHeight: 20,
color: 'panelForegroundSecondaryLabel',
paddingBottom: 16,
},
commSwooshContainer: {
flexGrow: 1,
flexShrink: 1,
alignItems: 'center',
justifyContent: 'center',
},
commSwoosh: {
resizeMode: 'center',
width: '100%',
height: '100%',
},
hyperlinkText: {
color: 'purpleLink',
},
}; };
export default RegistrationTerms; export default RegistrationTerms;
View Options

yarn.lock

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { Text } from 'react-native'; import { Text, View, Image, Linking } from 'react-native';
import RegistrationButtonContainer from './registration-button-container.react.js'; import RegistrationButtonContainer from './registration-button-container.react.js';
import RegistrationButton from './registration-button.react.js'; import RegistrationButton from './registration-button.react.js';
import RegistrationContainer from './registration-container.react.js'; import RegistrationContainer from './registration-container.react.js';
import RegistrationContentContainer from './registration-content-container.react.js'; import RegistrationContentContainer from './registration-content-container.react.js';
import { RegistrationContext } from './registration-context.js'; import { RegistrationContext } from './registration-context.js';
import type { RegistrationNavigationProp } from './registration-navigator.react.js'; import type { RegistrationNavigationProp } from './registration-navigator.react.js';
import type { import type {
CoolOrNerdMode, CoolOrNerdMode,
AccountSelection, AccountSelection,
AvatarData, AvatarData,
} from './registration-types.js'; } from './registration-types.js';
import commSwooshSource from '../../img/comm-swoosh.png';
import type { NavigationRoute } from '../../navigation/route-names.js'; import type { NavigationRoute } from '../../navigation/route-names.js';
import { useStyles } from '../../themes/colors.js'; import { useStyles } from '../../themes/colors.js';
export type RegistrationTermsParams = { export type RegistrationTermsParams = {
+userSelections: { +userSelections: {
+coolOrNerdMode: CoolOrNerdMode, +coolOrNerdMode: CoolOrNerdMode,
+keyserverUsername: string, +keyserverUsername: string,
+accountSelection: AccountSelection, +accountSelection: AccountSelection,
+avatarData: ?AvatarData, +avatarData: ?AvatarData,
}, },
}; };
const onTermsOfUsePressed = () => {
Linking.openURL('https://comm.app/terms');
};
const onPrivacyPolicyPressed = () => {
Linking.openURL('https://comm.app/privacy');
};
type Props = { type Props = {
+navigation: RegistrationNavigationProp<'RegistrationTerms'>, +navigation: RegistrationNavigationProp<'RegistrationTerms'>,
+route: NavigationRoute<'RegistrationTerms'>, +route: NavigationRoute<'RegistrationTerms'>,
}; };
function RegistrationTerms(props: Props): React.Node { function RegistrationTerms(props: Props): React.Node {
const registrationContext = React.useContext(RegistrationContext); const registrationContext = React.useContext(RegistrationContext);
invariant(registrationContext, 'registrationContext should be set'); invariant(registrationContext, 'registrationContext should be set');
const { register } = registrationContext; const { register } = registrationContext;
const [registrationInProgress, setRegistrationInProgress] = const [registrationInProgress, setRegistrationInProgress] =
React.useState(false); React.useState(false);
const { userSelections } = props.route.params; const { userSelections } = props.route.params;
const onProceed = React.useCallback(async () => { const onProceed = React.useCallback(async () => {
setRegistrationInProgress(true); setRegistrationInProgress(true);
try { try {
await register(userSelections); await register(userSelections);
} finally { } finally {
setRegistrationInProgress(false); setRegistrationInProgress(false);
} }
}, [register, userSelections]); }, [register, userSelections]);
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
/* eslint-disable react-native/no-raw-text */
const termsNotice = (
<Text style={styles.body}>
By registering, you are agreeing to our{' '}
<Text style={styles.hyperlinkText} onPress={onTermsOfUsePressed}>
Terms of Use
</Text>
{' and '}
<Text style={styles.hyperlinkText} onPress={onPrivacyPolicyPressed}>
Privacy Policy
</Text>
.
</Text>
);
/* eslint-enable react-native/no-raw-text */
return ( return (
<RegistrationContainer> <RegistrationContainer>
<RegistrationContentContainer> <RegistrationContentContainer style={styles.scrollViewContentContainer}>
<Text style={styles.header}>Finish registration</Text> <Text style={styles.header}>Finish registration</Text>
{termsNotice}
<View style={styles.commSwooshContainer}>
<Image source={commSwooshSource} style={styles.commSwoosh} />
</View>
</RegistrationContentContainer> </RegistrationContentContainer>
<RegistrationButtonContainer> <RegistrationButtonContainer>
<RegistrationButton <RegistrationButton
onPress={onProceed} onPress={onProceed}
label="Register" label="Register"
variant={registrationInProgress ? 'loading' : 'enabled'} variant={registrationInProgress ? 'loading' : 'enabled'}
/> />
</RegistrationButtonContainer> </RegistrationButtonContainer>
</RegistrationContainer> </RegistrationContainer>
); );
} }
const unboundStyles = { const unboundStyles = {
scrollViewContentContainer: {
flexGrow: 1,
},
header: { header: {
fontSize: 24, fontSize: 24,
color: 'panelForegroundLabel', color: 'panelForegroundLabel',
paddingBottom: 16, paddingBottom: 16,
}, },
body: {
fontFamily: 'Arial',
fontSize: 15,
lineHeight: 20,
color: 'panelForegroundSecondaryLabel',
paddingBottom: 16,
},
commSwooshContainer: {
flexGrow: 1,
flexShrink: 1,
alignItems: 'center',
justifyContent: 'center',
},
commSwoosh: {
resizeMode: 'center',
width: '100%',
height: '100%',
},
hyperlinkText: {
color: 'purpleLink',
},
}; };
export default RegistrationTerms; export default RegistrationTerms;