Page MenuHomePhabricator
Differential D5904

[native] [10/40] RN 0.70: Flow update
ClosedPublic
Actions

Authored by ashoat on Dec 17 2022, 7:53 PM.
Tags
None
Referenced Files
F3231408: D5904.id19494.diff
Tue, Nov 12, 11:22 AM
Unknown Object (File)
Sun, Nov 10, 5:55 PM
Unknown Object (File)
Sun, Nov 10, 7:31 AM
Unknown Object (File)
Mon, Nov 4, 9:49 PM
Unknown Object (File)
Mon, Nov 4, 8:24 AM
Unknown Object (File)
Mon, Nov 4, 8:24 AM
Unknown Object (File)
Sat, Nov 2, 3:33 AM
Unknown Object (File)
Sat, Nov 2, 3:33 AM
View All Files
Subscribers
atul

Details

Reviewers
tomek
bartek
Commits
rCOMM96720233b3bb: [native] [10/40] RN 0.70: Flow update
Summary

The .flowconfig and package.json changes come from React Native Upgrade Helper. The rest fix Flow errors uncovered by the update.

Historically I've split up Flow changes for a React Native upgrade, but this time there weren't too many!

Depends on D5903

Test Plan

Ran flow and also tested along with whole stack: test plan

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 17 2022, 7:53 PM
Herald added a subscriber: atul. · View Herald TranscriptDec 17 2022, 7:53 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 17 2022, 7:53 PM
Harbormaster failed remote builds in B14233: Diff 19467!
ashoat added a child revision: D5905: [native] [11/40] RN 0.70: Revert "[RN0.66] 41/n: Patch Easing types".Dec 17 2022, 7:54 PM
ashoat added inline comments.Dec 17 2022, 7:58 PM
native/.flowconfig
8 ↗(On Diff #19467)

Had to add this

native/calendar/calendar.react.js
200 ↗(On Diff #19467)

Flow errors exposed that we were doing this wrong

native/flow-typed/npm/react-native-reanimated_v2.x.x.js
38 ↗(On Diff #19467)

Flow didn't like that I was "shadowing" other names on line 487, so I had to change this

native/navigation/disconnected-bar.react.js
29 ↗(On Diff #19467)

Flow caught a bug here!

native/navigation/tab-bar.react.js
23 ↗(On Diff #19467)

And here!

patches/react-native-firebase+5.6.0.patch
270–273 ↗(On Diff #19467)

We had this hack here before to trick Flow into not giving errors, but it's actually not typed correctly. I fixed the type up to actually be correct this time

ashoat requested review of this revision.Dec 17 2022, 8:09 PM

Please ignore CI until the end of the stack

ashoat updated this revision to Diff 19494.Dec 18 2022, 8:14 PM

Fix new Flow error in web/electron.js

Harbormaster failed remote builds in B14255: Diff 19494!Dec 18 2022, 8:14 PM
ashoat updated this revision to Diff 19521.Dec 18 2022, 8:28 PM

Rebase

Harbormaster failed remote builds in B14282: Diff 19521!Dec 18 2022, 8:49 PM
ashoat updated this revision to Diff 19583.Dec 19 2022, 8:19 AM

Rebase

Harbormaster failed remote builds in B14334: Diff 19583!Dec 19 2022, 8:29 AM
ashoat updated this revision to Diff 19616.Dec 19 2022, 8:36 AM

Rebase

tomek accepted this revision.Dec 19 2022, 8:56 AM
tomek added inline comments.
native/media/file-utils.js
158–162 ↗(On Diff #19616)

I'm fine with this new version, but just curious: was it required by a new version of Flow?

This revision is now accepted and ready to land.Dec 19 2022, 8:56 AM
Harbormaster failed remote builds in B14367: Diff 19616!Dec 19 2022, 8:57 AM
ashoat added inline comments.Dec 19 2022, 9:42 AM
native/media/file-utils.js
158–162 ↗(On Diff #19616)

Yes it was. Flow was afraid that the console.log might have some side effect and so newLocalURI could become falsey somehow

ashoat updated this revision to Diff 19657.Dec 19 2022, 9:51 AM

Rebase

Harbormaster failed remote builds in B14406: Diff 19657!Dec 19 2022, 9:58 AM
ashoat updated this revision to Diff 19809.Dec 20 2022, 11:00 AM

Rebase

Harbormaster failed remote builds in B14549: Diff 19809!Dec 20 2022, 11:11 AM
This revision was landed with ongoing or failed builds.Dec 20 2022, 12:00 PM
Closed by commit rCOMM96720233b3bb: [native] [10/40] RN 0.70: Flow update (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM96720233b3bb: [native] [10/40] RN 0.70: Flow update.

Revision Contents
Changeset List

PathSize
keyserver/
1 line
2 lines
src/
database/
10 lines
updaters/
8 lines
landing/
1 line
2 lines
lib/
1 line
2 lines
shared/
16 lines
native/
6 lines
calendar/
11 lines
2 lines
flow-typed/
npm/
@react-navigation/
4 lines
168 lines
media/
2 lines
navigation/
2 lines
2 lines
2 lines
patches/
22 lines
web/
1 line
calendar/
2 lines
19 lines
2 lines
4 lines
8 lines

Diff 19850

View Options

keyserver/.flowconfig

Loading...
View Options

keyserver/package.json

Loading...
View Options

keyserver/src/database/database.js

Loading...
View Options

keyserver/src/updaters/thread-permission-updaters.js

Loading...
View Options

landing/.flowconfig

Loading...
View Options

landing/package.json

Loading...
View Options

lib/.flowconfig

Loading...
View Options

lib/package.json

Loading...
View Options

lib/shared/notif-utils.js

Loading...
View Options

native/.flowconfig

Loading...
View Options

native/calendar/calendar.react.js

Loading...
View Options

native/calendar/entry.react.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/native_v6.x.x.js

Loading...
View Options

native/flow-typed/npm/react-native-reanimated_v2.x.x.js

Loading...
View Options

native/media/file-utils.js

Loading...
View Options

native/navigation/disconnected-bar.react.js

Loading...
View Options

native/navigation/tab-bar.react.js

Loading...
View Options

native/package.json

Loading...
View Options

patches/react-native-firebase+5.6.0.patch

Loading...
View Options

web/.flowconfig

Loading...
View Options

web/calendar/entry.react.js

Loading...
View Options

web/electron.js

Loading...
View Options

web/package.json

Loading...
View Options

web/vector-utils.js

Loading...
View Options

yarn.lock

Loading...