[native] [3/40] RN 0.70: iOS stuff
ClosedPublic
Actions

Authored by ashoat on Dec 17 2022, 7:26 PM.

Details

Reviewers

tomek
bartek

Commits

rCOMM8383c5541411: [native] [3/40] RN 0.70: iOS stuff

Summary

These are the non-Podfile iOS changes from React Native Upgrade Helper. The project.pbxproj parts had to be "reverse engineered" from the patch there and then manually reapplied using Xcode... since those are pretty complicated, I'll try to describe inline.

Depends on D5896

Test Plan

Tested along with whole stack: test plan

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 17 2022, 7:26 PM

Herald added a subscriber: atul. · View Herald TranscriptDec 17 2022, 7:26 PM

ashoat added inline comments.Dec 17 2022, 7:29 PM

native/ios/Comm.xcodeproj/project.pbxproj
1019 ↗	(On Diff #19460)	Updated everywhere to be consistent
1041 ↗	(On Diff #19460)	Related to this: https://github.com/facebook/react-native/issues/34102
1044 ↗	(On Diff #19460)	Updated everywhere to be consistent
1146 ↗	(On Diff #19460)	Reanimated is updated later in the stack, and the build for the new version of Reanimated was failing without this change
1546–1553 ↗	(On Diff #19460)	Had to add these to get things to compile