Page MenuHomePhabricator

[native] [3/40] RN 0.70: iOS stuff
ClosedPublic

Authored by ashoat on Dec 17 2022, 7:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 5:55 PM
Unknown Object (File)
Wed, Nov 6, 7:10 PM
Unknown Object (File)
Wed, Nov 6, 6:25 AM
Unknown Object (File)
Mon, Nov 4, 8:23 AM
Unknown Object (File)
Sat, Nov 2, 11:21 PM
Unknown Object (File)
Sat, Nov 2, 3:33 AM
Unknown Object (File)
Sat, Nov 2, 3:33 AM
Unknown Object (File)
Sat, Nov 2, 3:33 AM
Subscribers

Details

Summary

These are the non-Podfile iOS changes from React Native Upgrade Helper. The project.pbxproj parts had to be "reverse engineered" from the patch there and then manually reapplied using Xcode... since those are pretty complicated, I'll try to describe inline.

Depends on D5896

Test Plan

Tested along with whole stack: test plan

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

native/ios/Comm.xcodeproj/project.pbxproj
1019 ↗(On Diff #19460)

Updated everywhere to be consistent

1041 ↗(On Diff #19460)
1044 ↗(On Diff #19460)

Updated everywhere to be consistent

1146 ↗(On Diff #19460)

Reanimated is updated later in the stack, and the build for the new version of Reanimated was failing without this change

1546–1553 ↗(On Diff #19460)

Had to add these to get things to compile

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 17 2022, 7:29 PM
Harbormaster failed remote builds in B14226: Diff 19460!

Please ignore CI until the end of the stack

This revision is now accepted and ready to land.Dec 19 2022, 4:41 AM
This revision was landed with ongoing or failed builds.Dec 20 2022, 12:00 PM
This revision was automatically updated to reflect the committed changes.