Page MenuHomePhabricator
Differential D5936

[native] [35/40] RN 0.70: Update to react-native-device-info@10.3.0
ClosedPublic
Actions

Authored by ashoat on Dec 19 2022, 7:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 7:22 AM
Unknown Object (File)
Sat, Mar 15, 7:18 AM
Unknown Object (File)
Tue, Mar 4, 2:36 AM
Unknown Object (File)
Tue, Mar 4, 2:36 AM
Unknown Object (File)
Tue, Mar 4, 2:36 AM
Unknown Object (File)
Tue, Mar 4, 2:36 AM
Unknown Object (File)
Tue, Mar 4, 2:36 AM
Unknown Object (File)
Tue, Mar 4, 2:36 AM
View All Files
Subscribers
atul

Details

Reviewers
tomek
bartek
Commits
rCOMM34834776ab7f: [native] [35/40] RN 0.70: Update to react-native-device-info@10.3.0
Summary

The old version was causing a warning around a deprecated usage of NativeEventEmitter.

Depends on D5935

Test Plan

went through the Release Notes and looked for any breaking changes or anything concerning isEmulator/isEmulatorSync (the only function we actually use on this package)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 19 2022, 7:19 AM
Herald added a subscriber: atul. · View Herald TranscriptDec 19 2022, 7:19 AM
ashoat added a child revision: D5937: [native] [36/40] RN 0.70: Update to react-native-orientation-locker@1.5.0.Dec 19 2022, 7:20 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 7:20 AM
Harbormaster failed remote builds in B14320: Diff 19563!
ashoat updated this revision to Diff 19608.Dec 19 2022, 8:23 AM

Rebase

ashoat updated this revision to Diff 19641.Dec 19 2022, 8:39 AM

Rebase

Harbormaster failed remote builds in B14359: Diff 19608!Dec 19 2022, 8:44 AM
ashoat published this revision for review.Dec 19 2022, 9:13 AM

Please ignore CI until the end of the stack

Harbormaster failed remote builds in B14392: Diff 19641!Dec 19 2022, 9:13 AM
ashoat updated this revision to Diff 19665.Dec 19 2022, 10:02 AM

Rebase

Harbormaster failed remote builds in B14414: Diff 19665!Dec 19 2022, 10:03 AM
ashoat updated this revision to Diff 19676.Dec 19 2022, 10:23 AM

Rebase

Harbormaster failed remote builds in B14424: Diff 19676!Dec 19 2022, 11:14 AM
ashoat updated this revision to Diff 19714.Dec 19 2022, 12:30 PM

Rebase

Harbormaster failed remote builds in B14459: Diff 19714!Dec 19 2022, 12:55 PM
ashoat updated this revision to Diff 19738.Dec 19 2022, 3:37 PM

Rebase

Harbormaster completed remote builds in B14482: Diff 19738.Dec 19 2022, 3:50 PM
bartek accepted this revision.Dec 20 2022, 3:41 AM
This revision is now accepted and ready to land.Dec 20 2022, 3:41 AM
ashoat updated this revision to Diff 19772.Dec 20 2022, 6:23 AM

Rebase

Harbormaster completed remote builds in B14515: Diff 19772.Dec 20 2022, 6:53 AM
tomek accepted this revision.Dec 20 2022, 9:00 AM
ashoat updated this revision to Diff 19834.Dec 20 2022, 11:03 AM

Rebase

Harbormaster completed remote builds in B14574: Diff 19834.Dec 20 2022, 11:48 AM
Closed by commit rCOMM34834776ab7f: [native] [35/40] RN 0.70: Update to react-native-device-info@10.3.0 (authored by ashoat). · Explain WhyDec 20 2022, 12:01 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM34834776ab7f: [native] [35/40] RN 0.70: Update to react-native-device-info@10.3.0.

Revision Contents
Changeset List

PathSize
native/
ios/
4 lines
2 lines
8 lines

Diff 19875

View Options

native/ios/Podfile.lock

Show All 27 Lines
import createIDs from './id-creator.js'; import createIDs from './id-creator.js';
import createMessages from './message-creator.js'; import createMessages from './message-creator.js';
import { import {
createInitialRolesForNewThread, createInitialRolesForNewThread,
getRolePermissionBlobs, getRolePermissionBlobs,
} from './role-creator.js'; } from './role-creator.js';
import type { UpdatesForCurrentSession } from './update-creator.js'; import type { UpdatesForCurrentSession } from './update-creator.js';
import { dbQuery, SQL } from '../database/database.js'; import { dbQuery, SQL } from '../database/database.js';
import { fetchMessageInfoByID } from '../fetchers/message-fetchers.js'; import {
fetchLatestEditMessageContentByID,
fetchMessageInfoByID,
} from '../fetchers/message-fetchers.js';
import { import {
determineThreadAncestry, determineThreadAncestry,
personalThreadQuery, personalThreadQuery,
} from '../fetchers/thread-fetchers.js'; } from '../fetchers/thread-fetchers.js';
import { import {
checkThreadPermission, checkThreadPermission,
validateCandidateMembers, validateCandidateMembers,
} from '../fetchers/thread-permission-fetchers.js'; } from '../fetchers/thread-permission-fetchers.js';
▲ Show 20 Lines • Show All 371 Lines • ▼ Show 20 Lines messageDatas.push({
}, },
}); });
} else { } else {
invariant(parentThreadID, 'parentThreadID should be set for sidebar'); invariant(parentThreadID, 'parentThreadID should be set for sidebar');
if (!sourceMessage || sourceMessage.type === messageTypes.SIDEBAR_SOURCE) { if (!sourceMessage || sourceMessage.type === messageTypes.SIDEBAR_SOURCE) {
throw new ServerError('invalid_parameters'); throw new ServerError('invalid_parameters');
} }
let editedSourceMessage = sourceMessage;
if (sourceMessageID && sourceMessage.type === messageTypes.TEXT) {
const editMessageContent = await fetchLatestEditMessageContentByID(
sourceMessageID,
);
if (editMessageContent) {
editedSourceMessage = {
...sourceMessage,
text: editMessageContent.text,
};
}
}
messageDatas.push( messageDatas.push(
{ {
type: messageTypes.SIDEBAR_SOURCE, type: messageTypes.SIDEBAR_SOURCE,
threadID: id, threadID: id,
creatorID: viewer.userID, creatorID: viewer.userID,
time, time,
sourceMessage, sourceMessage: editedSourceMessage,
}, },
{ {
type: messageTypes.CREATE_SIDEBAR, type: messageTypes.CREATE_SIDEBAR,
threadID: id, threadID: id,
creatorID: viewer.userID, creatorID: viewer.userID,
time, time,
sourceMessageAuthorID: sourceMessage.creatorID, sourceMessageAuthorID: sourceMessage.creatorID,
initialThreadState: { initialThreadState: {
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines
View Options

native/package.json

Show All 27 Lines
import createIDs from './id-creator.js'; import createIDs from './id-creator.js';
import createMessages from './message-creator.js'; import createMessages from './message-creator.js';
import { import {
createInitialRolesForNewThread, createInitialRolesForNewThread,
getRolePermissionBlobs, getRolePermissionBlobs,
} from './role-creator.js'; } from './role-creator.js';
import type { UpdatesForCurrentSession } from './update-creator.js'; import type { UpdatesForCurrentSession } from './update-creator.js';
import { dbQuery, SQL } from '../database/database.js'; import { dbQuery, SQL } from '../database/database.js';
import { fetchMessageInfoByID } from '../fetchers/message-fetchers.js'; import {
fetchLatestEditMessageContentByID,
fetchMessageInfoByID,
} from '../fetchers/message-fetchers.js';
import { import {
determineThreadAncestry, determineThreadAncestry,
personalThreadQuery, personalThreadQuery,
} from '../fetchers/thread-fetchers.js'; } from '../fetchers/thread-fetchers.js';
import { import {
checkThreadPermission, checkThreadPermission,
validateCandidateMembers, validateCandidateMembers,
} from '../fetchers/thread-permission-fetchers.js'; } from '../fetchers/thread-permission-fetchers.js';
▲ Show 20 Lines • Show All 371 Lines • ▼ Show 20 Lines messageDatas.push({
}, },
}); });
} else { } else {
invariant(parentThreadID, 'parentThreadID should be set for sidebar'); invariant(parentThreadID, 'parentThreadID should be set for sidebar');
if (!sourceMessage || sourceMessage.type === messageTypes.SIDEBAR_SOURCE) { if (!sourceMessage || sourceMessage.type === messageTypes.SIDEBAR_SOURCE) {
throw new ServerError('invalid_parameters'); throw new ServerError('invalid_parameters');
} }
let editedSourceMessage = sourceMessage;
if (sourceMessageID && sourceMessage.type === messageTypes.TEXT) {
const editMessageContent = await fetchLatestEditMessageContentByID(
sourceMessageID,
);
if (editMessageContent) {
editedSourceMessage = {
...sourceMessage,
text: editMessageContent.text,
};
}
}
messageDatas.push( messageDatas.push(
{ {
type: messageTypes.SIDEBAR_SOURCE, type: messageTypes.SIDEBAR_SOURCE,
threadID: id, threadID: id,
creatorID: viewer.userID, creatorID: viewer.userID,
time, time,
sourceMessage, sourceMessage: editedSourceMessage,
}, },
{ {
type: messageTypes.CREATE_SIDEBAR, type: messageTypes.CREATE_SIDEBAR,
threadID: id, threadID: id,
creatorID: viewer.userID, creatorID: viewer.userID,
time, time,
sourceMessageAuthorID: sourceMessage.creatorID, sourceMessageAuthorID: sourceMessage.creatorID,
initialThreadState: { initialThreadState: {
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines
View Options

yarn.lock

Show All 27 Lines
import createIDs from './id-creator.js'; import createIDs from './id-creator.js';
import createMessages from './message-creator.js'; import createMessages from './message-creator.js';
import { import {
createInitialRolesForNewThread, createInitialRolesForNewThread,
getRolePermissionBlobs, getRolePermissionBlobs,
} from './role-creator.js'; } from './role-creator.js';
import type { UpdatesForCurrentSession } from './update-creator.js'; import type { UpdatesForCurrentSession } from './update-creator.js';
import { dbQuery, SQL } from '../database/database.js'; import { dbQuery, SQL } from '../database/database.js';
import { fetchMessageInfoByID } from '../fetchers/message-fetchers.js'; import {
fetchLatestEditMessageContentByID,
fetchMessageInfoByID,
} from '../fetchers/message-fetchers.js';
import { import {
determineThreadAncestry, determineThreadAncestry,
personalThreadQuery, personalThreadQuery,
} from '../fetchers/thread-fetchers.js'; } from '../fetchers/thread-fetchers.js';
import { import {
checkThreadPermission, checkThreadPermission,
validateCandidateMembers, validateCandidateMembers,
} from '../fetchers/thread-permission-fetchers.js'; } from '../fetchers/thread-permission-fetchers.js';
▲ Show 20 Lines • Show All 371 Lines • ▼ Show 20 Lines messageDatas.push({
}, },
}); });
} else { } else {
invariant(parentThreadID, 'parentThreadID should be set for sidebar'); invariant(parentThreadID, 'parentThreadID should be set for sidebar');
if (!sourceMessage || sourceMessage.type === messageTypes.SIDEBAR_SOURCE) { if (!sourceMessage || sourceMessage.type === messageTypes.SIDEBAR_SOURCE) {
throw new ServerError('invalid_parameters'); throw new ServerError('invalid_parameters');
} }
let editedSourceMessage = sourceMessage;
if (sourceMessageID && sourceMessage.type === messageTypes.TEXT) {
const editMessageContent = await fetchLatestEditMessageContentByID(
sourceMessageID,
);
if (editMessageContent) {
editedSourceMessage = {
...sourceMessage,
text: editMessageContent.text,
};
}
}
messageDatas.push( messageDatas.push(
{ {
type: messageTypes.SIDEBAR_SOURCE, type: messageTypes.SIDEBAR_SOURCE,
threadID: id, threadID: id,
creatorID: viewer.userID, creatorID: viewer.userID,
time, time,
sourceMessage, sourceMessage: editedSourceMessage,
}, },
{ {
type: messageTypes.CREATE_SIDEBAR, type: messageTypes.CREATE_SIDEBAR,
threadID: id, threadID: id,
creatorID: viewer.userID, creatorID: viewer.userID,
time, time,
sourceMessageAuthorID: sourceMessage.creatorID, sourceMessageAuthorID: sourceMessage.creatorID,
initialThreadState: { initialThreadState: {
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines