Details

Reviewers

tomek
bartek
• jon

Commits

rCOMMe9abdd5e6769: [native] [7/40] RN 0.70: Get rid of Flipper

Summary

I was seeing build issues with the NotificationServiceExtension on iOS release builds until I disabled Flipper.

Flipper has always been a pain with builds and build times, and has always kind of sucked as a debugging tool. Instead, a later diff in this stack will introduce expo-dev-client, which has the ability to do JS debugging with Hermes.

Depends on D5900

Test Plan

Tested along with whole stack: test plan

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 17 2022, 7:47 PM

Herald added a reviewer: • jon. · View Herald TranscriptDec 17 2022, 7:47 PM

Herald added a subscriber: atul. · View Herald Transcript

ashoat added inline comments.Dec 17 2022, 7:47 PM

docs/dev_environment.md
288 ↗	(On Diff #19464)	cc @jon

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 17 2022, 7:48 PM

Harbormaster failed remote builds in B14230: Diff 19464!

ashoat added a child revision: D5902: [native] [8/40] RN 0.70: Ruby 2.7.5.Dec 17 2022, 7:48 PM

Please ignore CI until the end of the stack

Rebase

Harbormaster failed remote builds in B14279: Diff 19518!Dec 18 2022, 8:42 PM

Rebase

Harbormaster failed remote builds in B14331: Diff 19580!Dec 19 2022, 8:22 AM

tomek accepted this revision.Dec 19 2022, 8:42 AM

Rebase

Harbormaster failed remote builds in B14403: Diff 19654!Dec 19 2022, 9:54 AM

ashoat mentioned this in D5932: [native] [31/40] RN 0.70: First commit for new AndroidLifecycle Expo module.Dec 20 2022, 7:21 AM

• jon accepted this revision.Dec 20 2022, 9:37 AM

This revision is now accepted and ready to land.Dec 20 2022, 9:37 AM

Replace accidental tab characters in root package.json

Harbormaster failed remote builds in B14534: Diff 19791!Dec 20 2022, 10:32 AM

Rebase

Harbormaster failed remote builds in B14546: Diff 19806!Dec 20 2022, 11:05 AM

This revision was landed with ongoing or failed builds.Dec 20 2022, 12:00 PM

Closed by commit rCOMMe9abdd5e6769: [native] [7/40] RN 0.70: Get rid of Flipper (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMe9abdd5e6769: [native] [7/40] RN 0.70: Get rid of Flipper.

[native] [7/40] RN 0.70: Get rid of Flipper
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 19847

docs/dev_environment.md

docs/nix_dev_env.md

docs/nix_mobile_setup.md

docs/nix_web_workflows.md

native/android/app/build.gradle

native/android/app/src/debug/java/app/comm/android/ReactNativeFlipper.java

native/android/app/src/main/java/app/comm/android/MainApplication.java

native/android/gradle.properties

native/ios/Comm.xcodeproj/project.pbxproj

native/ios/Podfile

native/ios/Podfile.lock

native/package.json

native/redux/redux-setup.js

package.json

yarn.lock

[native] [7/40] RN 0.70: Get rid of FlipperClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 19847

docs/dev_environment.md

docs/nix_dev_env.md

docs/nix_mobile_setup.md

docs/nix_web_workflows.md

native/android/app/build.gradle

native/android/app/src/debug/java/app/comm/android/ReactNativeFlipper.java

native/android/app/src/main/java/app/comm/android/MainApplication.java

native/android/gradle.properties

native/ios/Comm.xcodeproj/project.pbxproj

native/ios/Podfile

native/ios/Podfile.lock

native/package.json

native/redux/redux-setup.js

package.json

yarn.lock

[native] [7/40] RN 0.70: Get rid of Flipper
ClosedPublic
Actions

Revision Contents
Changeset List