Page MenuHomePhabricator

[native] [27/40] RN 0.70: Patch react-native-camera to fix ViewPropTypes crash
ClosedPublic

Authored by ashoat on Dec 18 2022, 7:53 PM.
Tags
None
Referenced Files
F3231174: D5922.diff
Tue, Nov 12, 10:32 AM
Unknown Object (File)
Sun, Nov 10, 5:54 PM
Unknown Object (File)
Thu, Nov 7, 2:31 PM
Unknown Object (File)
Wed, Nov 6, 7:10 PM
Unknown Object (File)
Wed, Nov 6, 7:10 PM
Unknown Object (File)
Mon, Nov 4, 4:07 PM
Unknown Object (File)
Mon, Nov 4, 4:06 PM
Unknown Object (File)
Mon, Nov 4, 4:06 PM
Subscribers

Details

Summary

Our old version of react-native-camera was erroring due to an import of ViewPropTypes from react-native, which has been deprecated. I tried to update it, but that didn't fix the issue, so I added a patch. Then I realized the update broke the Android build, so I took it out.

This package appears to have been deprecated sometime in the last year. ENG-1520 tracks the long-term solution, but I don't have the cycles to handle that right now unfortunately.

Depends on D5921

Test Plan
  1. Confirm JS error due to ViewPropTypes import no longer occurs
  2. Tested along with whole stack: test plan (includes testing camera functionality)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 7:53 PM
Harbormaster failed remote builds in B14251: Diff 19490!
ashoat retitled this revision from [native] [26/40] RN 0.70: Patch react-native-camera to fix ViewPropTypes crash to [native] [27/40] RN 0.70: Patch react-native-camera to fix ViewPropTypes crash.Dec 18 2022, 8:05 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:32 PM
Harbormaster failed remote builds in B14272: Diff 19511!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:58 PM
Harbormaster failed remote builds in B14299: Diff 19538!
ashoat published this revision for review.Dec 19 2022, 9:11 AM

Please ignore CI until the end of the stack

This revision is now accepted and ready to land.Dec 20 2022, 3:30 AM