Page MenuHomePhabricator

[native] [36/40] RN 0.70: Update to react-native-orientation-locker@1.5.0
ClosedPublic

Authored by ashoat on Dec 19 2022, 7:20 AM.
Tags
None
Referenced Files
F3231804: D5937.id19564.diff
Tue, Nov 12, 12:15 PM
F3228670: D5937.id19715.diff
Tue, Nov 12, 2:58 AM
Unknown Object (File)
Sun, Nov 10, 5:54 PM
Unknown Object (File)
Thu, Nov 7, 5:53 AM
Unknown Object (File)
Mon, Nov 4, 8:28 AM
Unknown Object (File)
Mon, Nov 4, 8:27 AM
Unknown Object (File)
Mon, Nov 4, 8:27 AM
Unknown Object (File)
Mon, Nov 4, 1:12 AM
Subscribers

Details

Summary

The old version was causing a warning around a deprecated usage of NativeEventEmitter.

Depends on D5936

Test Plan
  1. Went through the (incomplete) Release Notes and looked for any breaking changes
  2. Checked the docs to make sure all the APIs we use are still supported
  3. Tested along with whole stack: test plan (includes testing orientation changes)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 7:21 AM
Harbormaster failed remote builds in B14321: Diff 19564!
ashoat published this revision for review.Dec 19 2022, 9:13 AM

Please ignore CI until the end of the stack

This revision is now accepted and ready to land.Dec 20 2022, 3:46 AM