Page MenuHomePhabricator
Differential D5937

[native] [36/40] RN 0.70: Update to react-native-orientation-locker@1.5.0
ClosedPublic
Actions

Authored by ashoat on Dec 19 2022, 7:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 7:05 AM
Unknown Object (File)
Wed, Mar 12, 1:00 AM
Unknown Object (File)
Sat, Mar 8, 6:32 PM
Unknown Object (File)
Sat, Mar 8, 6:32 PM
Unknown Object (File)
Sat, Mar 8, 6:32 PM
Unknown Object (File)
Sat, Mar 8, 6:32 PM
Unknown Object (File)
Sat, Mar 8, 6:32 PM
Unknown Object (File)
Sat, Mar 8, 6:32 PM
View All Files
Subscribers
atul

Details

Reviewers
tomek
bartek
Commits
rCOMM8c0e06d046c3: [native] [36/40] RN 0.70: Update to react-native-orientation-locker@1.5.0
Summary

The old version was causing a warning around a deprecated usage of NativeEventEmitter.

Depends on D5936

Test Plan
  1. Went through the (incomplete) Release Notes and looked for any breaking changes
  2. Checked the docs to make sure all the APIs we use are still supported
  3. Tested along with whole stack: test plan (includes testing orientation changes)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 19 2022, 7:20 AM
Herald added a subscriber: atul. · View Herald TranscriptDec 19 2022, 7:20 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 7:21 AM
Harbormaster failed remote builds in B14321: Diff 19564!
ashoat added a child revision: D5938: [native] [37/40] RN 0.70: Update to react-native-floating-action@1.22.0.Dec 19 2022, 7:23 AM
ashoat updated this revision to Diff 19609.Dec 19 2022, 8:23 AM

Rebase

ashoat updated this revision to Diff 19642.Dec 19 2022, 8:39 AM

Rebase

Harbormaster failed remote builds in B14360: Diff 19609!Dec 19 2022, 8:46 AM
ashoat published this revision for review.Dec 19 2022, 9:13 AM

Please ignore CI until the end of the stack

Harbormaster failed remote builds in B14393: Diff 19642!Dec 19 2022, 9:14 AM
ashoat updated this revision to Diff 19666.Dec 19 2022, 10:02 AM

Rebase

Harbormaster failed remote builds in B14415: Diff 19666!Dec 19 2022, 10:05 AM
ashoat updated this revision to Diff 19677.Dec 19 2022, 10:23 AM

Rebase

Harbormaster failed remote builds in B14425: Diff 19677!Dec 19 2022, 11:15 AM
ashoat updated this revision to Diff 19715.Dec 19 2022, 12:31 PM

Rebase

Harbormaster failed remote builds in B14460: Diff 19715!Dec 19 2022, 12:57 PM
ashoat updated this revision to Diff 19739.Dec 19 2022, 3:37 PM

Rebase

Harbormaster completed remote builds in B14483: Diff 19739.Dec 19 2022, 3:50 PM
bartek accepted this revision.Dec 20 2022, 3:46 AM
This revision is now accepted and ready to land.Dec 20 2022, 3:46 AM
ashoat updated this revision to Diff 19773.Dec 20 2022, 6:23 AM

Rebase

Harbormaster completed remote builds in B14516: Diff 19773.Dec 20 2022, 6:56 AM
tomek accepted this revision.Dec 20 2022, 9:00 AM
ashoat updated this revision to Diff 19835.Dec 20 2022, 11:03 AM

Rebase

Harbormaster completed remote builds in B14575: Diff 19835.Dec 20 2022, 11:50 AM
Closed by commit rCOMM8c0e06d046c3: [native] [36/40] RN 0.70: Update to react-native-orientation-locker@1.5.0 (authored by ashoat). · Explain WhyDec 20 2022, 12:01 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM8c0e06d046c3: [native] [36/40] RN 0.70: Update to react-native-orientation-locker@1.5.0.

Revision Contents
Changeset List

PathSize
native/
ios/
6 lines
2 lines
patches/
react-native-orientation-locker+1.5.0.patch
react-native-orientation-locker+1.1.6.patch
10 lines
8 lines

Diff 19876

View Options

native/ios/Podfile.lock

// @flow // @flow
import t, { type TInterface } from 'tcomb'; import t, { type TInterface } from 'tcomb';
import type { import type {
UserSearchRequest, UserSearchRequest,
UserSearchResult, UserSearchResult,
ExactUserSearchRequest,
ExactUserSearchResult,
} from 'lib/types/search-types.js'; } from 'lib/types/search-types.js';
import { globalAccountUserInfoValidator } from 'lib/types/user-types.js'; import { globalAccountUserInfoValidator } from 'lib/types/user-types.js';
import { tShape } from 'lib/utils/validation-utils.js'; import { tShape } from 'lib/utils/validation-utils.js';
import { searchForUsers } from '../search/users.js'; import { searchForUsers, searchForUser } from '../search/users.js';
import type { Viewer } from '../session/viewer.js'; import type { Viewer } from '../session/viewer.js';
import { validateInput, validateOutput } from '../utils/validation-utils.js'; import { validateInput, validateOutput } from '../utils/validation-utils.js';
const userSearchRequestInputValidator = tShape<UserSearchRequest>({ const userSearchRequestInputValidator = tShape<UserSearchRequest>({
prefix: t.maybe(t.String), prefix: t.maybe(t.String),
}); });
export const userSearchResultValidator: TInterface<UserSearchResult> = export const userSearchResultValidator: TInterface<UserSearchResult> =
Show All 14 Lines): Promise<UserSearchResult> {
const result = { userInfos: searchResults }; const result = { userInfos: searchResults };
return validateOutput( return validateOutput(
viewer.platformDetails, viewer.platformDetails,
userSearchResultValidator, userSearchResultValidator,
result, result,
); );
} }
export { userSearchResponder }; const exactUserSearchRequestInputValidator = tShape<ExactUserSearchRequest>({
username: t.String,
});
const exactUserSearchResultValidator = tShape<ExactUserSearchResult>({
userInfo: t.maybe(globalAccountUserInfoValidator),
});
async function exactUserSearchResponder(
viewer: Viewer,
input: mixed,
): Promise<ExactUserSearchResult> {
const request = await validateInput(
viewer,
exactUserSearchRequestInputValidator,
input,
);
const searchResult = await searchForUser(request.username);
const result = { userInfo: searchResult };
return validateOutput(
viewer.platformDetails,
exactUserSearchResultValidator,
result,
);
}
export { userSearchResponder, exactUserSearchResponder };
View Options

native/package.json

// @flow // @flow
import t, { type TInterface } from 'tcomb'; import t, { type TInterface } from 'tcomb';
import type { import type {
UserSearchRequest, UserSearchRequest,
UserSearchResult, UserSearchResult,
ExactUserSearchRequest,
ExactUserSearchResult,
} from 'lib/types/search-types.js'; } from 'lib/types/search-types.js';
import { globalAccountUserInfoValidator } from 'lib/types/user-types.js'; import { globalAccountUserInfoValidator } from 'lib/types/user-types.js';
import { tShape } from 'lib/utils/validation-utils.js'; import { tShape } from 'lib/utils/validation-utils.js';
import { searchForUsers } from '../search/users.js'; import { searchForUsers, searchForUser } from '../search/users.js';
import type { Viewer } from '../session/viewer.js'; import type { Viewer } from '../session/viewer.js';
import { validateInput, validateOutput } from '../utils/validation-utils.js'; import { validateInput, validateOutput } from '../utils/validation-utils.js';
const userSearchRequestInputValidator = tShape<UserSearchRequest>({ const userSearchRequestInputValidator = tShape<UserSearchRequest>({
prefix: t.maybe(t.String), prefix: t.maybe(t.String),
}); });
export const userSearchResultValidator: TInterface<UserSearchResult> = export const userSearchResultValidator: TInterface<UserSearchResult> =
Show All 14 Lines): Promise<UserSearchResult> {
const result = { userInfos: searchResults }; const result = { userInfos: searchResults };
return validateOutput( return validateOutput(
viewer.platformDetails, viewer.platformDetails,
userSearchResultValidator, userSearchResultValidator,
result, result,
); );
} }
export { userSearchResponder }; const exactUserSearchRequestInputValidator = tShape<ExactUserSearchRequest>({
username: t.String,
});
const exactUserSearchResultValidator = tShape<ExactUserSearchResult>({
userInfo: t.maybe(globalAccountUserInfoValidator),
});
async function exactUserSearchResponder(
viewer: Viewer,
input: mixed,
): Promise<ExactUserSearchResult> {
const request = await validateInput(
viewer,
exactUserSearchRequestInputValidator,
input,
);
const searchResult = await searchForUser(request.username);
const result = { userInfo: searchResult };
return validateOutput(
viewer.platformDetails,
exactUserSearchResultValidator,
result,
);
}
export { userSearchResponder, exactUserSearchResponder };
View Options

patches/react-native-orientation-locker+1.1.6.patch

// @flow // @flow
import t, { type TInterface } from 'tcomb'; import t, { type TInterface } from 'tcomb';
import type { import type {
UserSearchRequest, UserSearchRequest,
UserSearchResult, UserSearchResult,
ExactUserSearchRequest,
ExactUserSearchResult,
} from 'lib/types/search-types.js'; } from 'lib/types/search-types.js';
import { globalAccountUserInfoValidator } from 'lib/types/user-types.js'; import { globalAccountUserInfoValidator } from 'lib/types/user-types.js';
import { tShape } from 'lib/utils/validation-utils.js'; import { tShape } from 'lib/utils/validation-utils.js';
import { searchForUsers } from '../search/users.js'; import { searchForUsers, searchForUser } from '../search/users.js';
import type { Viewer } from '../session/viewer.js'; import type { Viewer } from '../session/viewer.js';
import { validateInput, validateOutput } from '../utils/validation-utils.js'; import { validateInput, validateOutput } from '../utils/validation-utils.js';
const userSearchRequestInputValidator = tShape<UserSearchRequest>({ const userSearchRequestInputValidator = tShape<UserSearchRequest>({
prefix: t.maybe(t.String), prefix: t.maybe(t.String),
}); });
export const userSearchResultValidator: TInterface<UserSearchResult> = export const userSearchResultValidator: TInterface<UserSearchResult> =
Show All 14 Lines): Promise<UserSearchResult> {
const result = { userInfos: searchResults }; const result = { userInfos: searchResults };
return validateOutput( return validateOutput(
viewer.platformDetails, viewer.platformDetails,
userSearchResultValidator, userSearchResultValidator,
result, result,
); );
} }
export { userSearchResponder }; const exactUserSearchRequestInputValidator = tShape<ExactUserSearchRequest>({
username: t.String,
});
const exactUserSearchResultValidator = tShape<ExactUserSearchResult>({
userInfo: t.maybe(globalAccountUserInfoValidator),
});
async function exactUserSearchResponder(
viewer: Viewer,
input: mixed,
): Promise<ExactUserSearchResult> {
const request = await validateInput(
viewer,
exactUserSearchRequestInputValidator,
input,
);
const searchResult = await searchForUser(request.username);
const result = { userInfo: searchResult };
return validateOutput(
viewer.platformDetails,
exactUserSearchResultValidator,
result,
);
}
export { userSearchResponder, exactUserSearchResponder };
View Options

patches/react-native-orientation-locker+1.5.0.patch

// @flow // @flow
import t, { type TInterface } from 'tcomb'; import t, { type TInterface } from 'tcomb';
import type { import type {
UserSearchRequest, UserSearchRequest,
UserSearchResult, UserSearchResult,
ExactUserSearchRequest,
ExactUserSearchResult,
} from 'lib/types/search-types.js'; } from 'lib/types/search-types.js';
import { globalAccountUserInfoValidator } from 'lib/types/user-types.js'; import { globalAccountUserInfoValidator } from 'lib/types/user-types.js';
import { tShape } from 'lib/utils/validation-utils.js'; import { tShape } from 'lib/utils/validation-utils.js';
import { searchForUsers } from '../search/users.js'; import { searchForUsers, searchForUser } from '../search/users.js';
import type { Viewer } from '../session/viewer.js'; import type { Viewer } from '../session/viewer.js';
import { validateInput, validateOutput } from '../utils/validation-utils.js'; import { validateInput, validateOutput } from '../utils/validation-utils.js';
const userSearchRequestInputValidator = tShape<UserSearchRequest>({ const userSearchRequestInputValidator = tShape<UserSearchRequest>({
prefix: t.maybe(t.String), prefix: t.maybe(t.String),
}); });
export const userSearchResultValidator: TInterface<UserSearchResult> = export const userSearchResultValidator: TInterface<UserSearchResult> =
Show All 14 Lines): Promise<UserSearchResult> {
const result = { userInfos: searchResults }; const result = { userInfos: searchResults };
return validateOutput( return validateOutput(
viewer.platformDetails, viewer.platformDetails,
userSearchResultValidator, userSearchResultValidator,
result, result,
); );
} }
export { userSearchResponder }; const exactUserSearchRequestInputValidator = tShape<ExactUserSearchRequest>({
username: t.String,
});
const exactUserSearchResultValidator = tShape<ExactUserSearchResult>({
userInfo: t.maybe(globalAccountUserInfoValidator),
});
async function exactUserSearchResponder(
viewer: Viewer,
input: mixed,
): Promise<ExactUserSearchResult> {
const request = await validateInput(
viewer,
exactUserSearchRequestInputValidator,
input,
);
const searchResult = await searchForUser(request.username);
const result = { userInfo: searchResult };
return validateOutput(
viewer.platformDetails,
exactUserSearchResultValidator,
result,
);
}
export { userSearchResponder, exactUserSearchResponder };
View Options

yarn.lock

// @flow // @flow
import t, { type TInterface } from 'tcomb'; import t, { type TInterface } from 'tcomb';
import type { import type {
UserSearchRequest, UserSearchRequest,
UserSearchResult, UserSearchResult,
ExactUserSearchRequest,
ExactUserSearchResult,
} from 'lib/types/search-types.js'; } from 'lib/types/search-types.js';
import { globalAccountUserInfoValidator } from 'lib/types/user-types.js'; import { globalAccountUserInfoValidator } from 'lib/types/user-types.js';
import { tShape } from 'lib/utils/validation-utils.js'; import { tShape } from 'lib/utils/validation-utils.js';
import { searchForUsers } from '../search/users.js'; import { searchForUsers, searchForUser } from '../search/users.js';
import type { Viewer } from '../session/viewer.js'; import type { Viewer } from '../session/viewer.js';
import { validateInput, validateOutput } from '../utils/validation-utils.js'; import { validateInput, validateOutput } from '../utils/validation-utils.js';
const userSearchRequestInputValidator = tShape<UserSearchRequest>({ const userSearchRequestInputValidator = tShape<UserSearchRequest>({
prefix: t.maybe(t.String), prefix: t.maybe(t.String),
}); });
export const userSearchResultValidator: TInterface<UserSearchResult> = export const userSearchResultValidator: TInterface<UserSearchResult> =
Show All 14 Lines): Promise<UserSearchResult> {
const result = { userInfos: searchResults }; const result = { userInfos: searchResults };
return validateOutput( return validateOutput(
viewer.platformDetails, viewer.platformDetails,
userSearchResultValidator, userSearchResultValidator,
result, result,
); );
} }
export { userSearchResponder }; const exactUserSearchRequestInputValidator = tShape<ExactUserSearchRequest>({
username: t.String,
});
const exactUserSearchResultValidator = tShape<ExactUserSearchResult>({
userInfo: t.maybe(globalAccountUserInfoValidator),
});
async function exactUserSearchResponder(
viewer: Viewer,
input: mixed,
): Promise<ExactUserSearchResult> {
const request = await validateInput(
viewer,
exactUserSearchRequestInputValidator,
input,
);
const searchResult = await searchForUser(request.username);
const result = { userInfo: searchResult };
return validateOutput(
viewer.platformDetails,
exactUserSearchResultValidator,
result,
);
}
export { userSearchResponder, exactUserSearchResponder };