Page MenuHomePhabricator

[native] [22/40] RN 0.70: Get rid of comm-react-native-codegen
ClosedPublic

Authored by ashoat on Dec 18 2022, 7:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 5:54 PM
Unknown Object (File)
Sun, Nov 10, 10:22 AM
Unknown Object (File)
Wed, Nov 6, 7:10 PM
Unknown Object (File)
Sun, Nov 3, 6:39 PM
Unknown Object (File)
Sat, Nov 2, 3:34 AM
Unknown Object (File)
Sat, Nov 2, 12:25 AM
Unknown Object (File)
Sat, Nov 2, 12:25 AM
Unknown Object (File)
Sat, Nov 2, 12:25 AM
Subscribers

Details

Summary

Before the preceding diff, we had CommCoreModule's codegen (yarn codegen-jsi) using a different version of react-native-codegen than the transitive dependency from react-native. The versions started drifting when we introduced comm-react-native-codegen beacuse we wanted to patch our usage of react-native-codegen without affecting the primary version.

After making the versions of both react-native-codegens match again in the preceding diff, I started seeing this Yarn issue: https://github.com/yarnpkg/yarn/issues/7509

In that diff I also removed the patchfile. Given we don't need the patchfile anymore, we can circumvent the Yarn issue by replacing comm-react-native-codegen with a normal react-native-codegen dependency.

Test Plan

Tested along with whole stack: test plan

Depends on D5915

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 7:22 PM
Harbormaster failed remote builds in B14245: Diff 19484!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:26 PM
Harbormaster failed remote builds in B14267: Diff 19506!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:58 PM
Harbormaster failed remote builds in B14294: Diff 19533!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 8:37 AM
Harbormaster failed remote builds in B14346: Diff 19595!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 9:05 AM
Harbormaster failed remote builds in B14379: Diff 19628!

Please ignore CI until the end of the stack

This revision is now accepted and ready to land.Dec 20 2022, 5:17 AM
This revision was landed with ongoing or failed builds.Dec 20 2022, 12:01 PM
This revision was automatically updated to reflect the committed changes.