Page MenuHomePhabricator

[native] [30/40] RN 0.70: Patch react-native-firebase to avoid Android NativeEventEmitter warning
ClosedPublic

Authored by ashoat on Dec 18 2022, 8:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 5:54 PM
Unknown Object (File)
Fri, Nov 8, 4:37 PM
Unknown Object (File)
Wed, Nov 6, 6:25 AM
Unknown Object (File)
Tue, Nov 5, 7:29 AM
Unknown Object (File)
Tue, Nov 5, 7:28 AM
Unknown Object (File)
Mon, Nov 4, 8:26 AM
Unknown Object (File)
Mon, Nov 4, 8:26 AM
Unknown Object (File)
Mon, Nov 4, 8:26 AM
Subscribers

Details

Summary

Without this change a warning is printed. The methods don't need to be filled in, they just need to be defined. Here's an example of react-native-orientation-locker fixing the same issue.

The right long-term solution is to migrate all of our Android notifs logic to be using our own modules, but in order to unblock the React Native update I'm just patching this now.

Depends on D5924

Test Plan
  1. Confirm Android NativeEventEmitter warning is no longer printed
  2. Tested along with whole stack: test plan (includes testing notifs on Android)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:03 PM
Harbormaster failed remote builds in B14254: Diff 19493!
ashoat retitled this revision from [native] [29/40] RN 0.70: Patch react-native-firebase to avoid Android NativeEventEmitter warning to [native] [30/40] RN 0.70: Patch react-native-firebase to avoid Android NativeEventEmitter warning.Dec 18 2022, 8:06 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 9:37 PM
Harbormaster failed remote builds in B14302: Diff 19541!
ashoat published this revision for review.Dec 19 2022, 9:11 AM

Please ignore CI until the end of the stack

This revision is now accepted and ready to land.Dec 20 2022, 7:12 AM