Page MenuHomePhabricator

[native] [19/40] RN 0.70: Type @expo/vector-icons
ClosedPublic

Authored by ashoat on Dec 18 2022, 7:07 PM.
Tags
None
Referenced Files
F3332643: D5913.id19818.diff
Thu, Nov 21, 12:41 AM
F3329398: D5913.id19481.diff
Wed, Nov 20, 4:53 PM
Unknown Object (File)
Mon, Nov 18, 5:24 PM
Unknown Object (File)
Mon, Nov 18, 4:17 PM
Unknown Object (File)
Sun, Nov 17, 5:18 PM
Unknown Object (File)
Thu, Nov 14, 10:09 AM
Unknown Object (File)
Thu, Nov 14, 9:32 AM
Unknown Object (File)
Thu, Nov 14, 9:22 AM
Subscribers

Details

Summary

I checked out the latest react-native-vector-icons NPM package and pulled the glyph types out of there. Mostly handled the rest myself.

Depends on D5912

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 7:09 PM
Harbormaster failed remote builds in B14242: Diff 19481!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:23 PM
Harbormaster failed remote builds in B14264: Diff 19503!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:54 PM
Harbormaster failed remote builds in B14291: Diff 19530!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 8:33 AM
Harbormaster failed remote builds in B14343: Diff 19592!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 9:02 AM
Harbormaster failed remote builds in B14376: Diff 19625!

Please ignore CI until the end of the stack

tomek added inline comments.
native/components/action-row.react.js
11–14 ↗(On Diff #19698)

Why do we need to use explicit exact? I remember that it is a good idea in flow-typed definitions, but this isn't a part of it.

This revision is now accepted and ready to land.Dec 20 2022, 5:11 AM
native/components/action-row.react.js
11–14 ↗(On Diff #19698)

Oops!! We don't, not sure what I was thinking. Will fix this before landing

Get rid of explicit exact

This revision was landed with ongoing or failed builds.Dec 20 2022, 12:01 PM
This revision was automatically updated to reflect the committed changes.