Page MenuHomePhabricator
Differential D5913

[native] [19/40] RN 0.70: Type @expo/vector-icons
ClosedPublic
Actions

Authored by ashoat on Dec 18 2022, 7:07 PM.
Tags
None
Referenced Files
F3332643: D5913.id19818.diff
Thu, Nov 21, 12:41 AM
Unknown Object (File)
Wed, Nov 20, 4:53 PM
Unknown Object (File)
Mon, Nov 18, 5:24 PM
Unknown Object (File)
Mon, Nov 18, 4:17 PM
Unknown Object (File)
Sun, Nov 17, 5:18 PM
Unknown Object (File)
Thu, Nov 14, 10:09 AM
Unknown Object (File)
Thu, Nov 14, 9:32 AM
Unknown Object (File)
Thu, Nov 14, 9:22 AM
View All Files
Subscribers
atul

Details

Reviewers
tomek
Commits
rCOMMe2509e83ceea: [native] [19/40] RN 0.70: Type @expo/vector-icons
Summary

I checked out the latest react-native-vector-icons NPM package and pulled the glyph types out of there. Mostly handled the rest myself.

Depends on D5912

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Dec 18 2022, 7:07 PM
Herald added a subscriber: atul. · View Herald TranscriptDec 18 2022, 7:07 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 7:09 PM
Harbormaster failed remote builds in B14242: Diff 19481!
ashoat added a child revision: D5914: [native] [20/40] RN 0.70: Replace deprecated icons.Dec 18 2022, 7:10 PM
ashoat updated this revision to Diff 19503.Dec 18 2022, 8:17 PM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:23 PM
Harbormaster failed remote builds in B14264: Diff 19503!
ashoat updated this revision to Diff 19530.Dec 18 2022, 8:30 PM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:54 PM
Harbormaster failed remote builds in B14291: Diff 19530!
ashoat updated this revision to Diff 19592.Dec 19 2022, 8:21 AM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 8:33 AM
Harbormaster failed remote builds in B14343: Diff 19592!
ashoat updated this revision to Diff 19625.Dec 19 2022, 8:37 AM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 9:02 AM
Harbormaster failed remote builds in B14376: Diff 19625!
ashoat requested review of this revision.Dec 19 2022, 9:10 AM

Please ignore CI until the end of the stack

ashoat updated this revision to Diff 19698.Dec 19 2022, 12:28 PM

Rebase

Harbormaster failed remote builds in B14443: Diff 19698!Dec 19 2022, 12:34 PM
tomek accepted this revision.Dec 20 2022, 5:11 AM
tomek added inline comments.
native/components/action-row.react.js
11–14 ↗(On Diff #19698)

Why do we need to use explicit exact? I remember that it is a good idea in flow-typed definitions, but this isn't a part of it.

This revision is now accepted and ready to land.Dec 20 2022, 5:11 AM
ashoat added inline comments.Dec 20 2022, 5:49 AM
native/components/action-row.react.js
11–14 ↗(On Diff #19698)

Oops!! We don't, not sure what I was thinking. Will fix this before landing

ashoat updated this revision to Diff 19756.Dec 20 2022, 6:21 AM

Get rid of explicit exact

Harbormaster failed remote builds in B14499: Diff 19756!Dec 20 2022, 6:25 AM
ashoat updated this revision to Diff 19818.Dec 20 2022, 11:01 AM

Rebase

Harbormaster failed remote builds in B14558: Diff 19818!Dec 20 2022, 11:13 AM
This revision was landed with ongoing or failed builds.Dec 20 2022, 12:01 PM
Closed by commit rCOMMe2509e83ceea: [native] [19/40] RN 0.70: Type @expo/vector-icons (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMe2509e83ceea: [native] [19/40] RN 0.70: Type @expo/vector-icons.

Revision Contents
Changeset List

PathSize
native/
chat/
settings/
2 lines
components/
5 lines
2 lines
2 lines
flow-typed/
npm/
@expo/
179 lines

Diff 19756

View Options

native/chat/settings/thread-settings-list-action.react.js

Loading...
View Options

native/components/action-row.react.js

Loading...
View Options

native/components/comm-icon.react.js

Loading...
View Options

native/components/swmansion-icon.react.js

Loading...
View Options

native/flow-typed/npm/@expo/vector-icons_vx.x.x.js

Loading...