Details

Reviewers

Commits

rCOMMe2509e83ceea: [native] [19/40] RN 0.70: Type @expo/vector-icons

Summary

I checked out the latest react-native-vector-icons NPM package and pulled the glyph types out of there. Mostly handled the rest myself.

Depends on D5912

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Dec 19 2022, 3:07 AM

Herald added a subscriber: atul. · View Herald TranscriptDec 19 2022, 3:07 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 3:09 AM

Harbormaster failed remote builds in B14242: Diff 19481!

ashoat added a child revision: D5914: [native] [20/40] RN 0.70: Replace deprecated icons.Dec 19 2022, 3:10 AM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 4:23 AM

Harbormaster failed remote builds in B14264: Diff 19503!

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 4:54 AM

Harbormaster failed remote builds in B14291: Diff 19530!

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 4:33 PM

Harbormaster failed remote builds in B14343: Diff 19592!

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 5:02 PM

Harbormaster failed remote builds in B14376: Diff 19625!

Please ignore CI until the end of the stack

Rebase

Harbormaster failed remote builds in B14443: Diff 19698!Dec 19 2022, 8:34 PM

tomek accepted this revision.Dec 20 2022, 1:11 PM

tomek added inline comments.

native/components/action-row.react.js
11–14 ↗	(On Diff #19698)	Why do we need to use explicit exact? I remember that it is a good idea in flow-typed definitions, but this isn't a part of it.

This revision is now accepted and ready to land.Dec 20 2022, 1:11 PM

ashoat added inline comments.Dec 20 2022, 1:49 PM

native/components/action-row.react.js
11–14 ↗	(On Diff #19698)	Oops!! We don't, not sure what I was thinking. Will fix this before landing

Get rid of explicit exact

Harbormaster failed remote builds in B14499: Diff 19756!Dec 20 2022, 2:25 PM

Rebase

Harbormaster failed remote builds in B14558: Diff 19818!Dec 20 2022, 7:13 PM

This revision was landed with ongoing or failed builds.Dec 20 2022, 8:01 PM

Closed by commit rCOMMe2509e83ceea: [native] [19/40] RN 0.70: Type @expo/vector-icons. · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMe2509e83ceea: [native] [19/40] RN 0.70: Type @expo/vector-icons.

[native] [19/40] RN 0.70: Type @expo/vector-icons
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 19625

native/chat/settings/thread-settings-list-action.react.js

native/components/action-row.react.js

native/components/comm-icon.react.js

native/components/swmansion-icon.react.js

native/flow-typed/npm/@expo/vector-icons_vx.x.x.js

[native] [19/40] RN 0.70: Type @expo/vector-iconsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 19625

native/chat/settings/thread-settings-list-action.react.js

native/components/action-row.react.js

native/components/comm-icon.react.js

native/components/swmansion-icon.react.js

native/flow-typed/npm/@expo/vector-icons_vx.x.x.js

[native] [19/40] RN 0.70: Type @expo/vector-icons
ClosedPublic
Actions

Revision Contents
Changeset List