Details

Reviewers

tomek
bartek

Commits

rCOMM15386f745850: [native] [34/40] RN 0.70: Update to react-native-gesture-handler@2.8.0

Summary

This wasn't strictly necessary, but npx @rnx-kit/dep-check --write recommended updating, and we were on an ancient version.

Test Plan

I reviewed the Release Notes and found no breaking changes that might affect us, other than the ones updated here
Tested along with whole stack: test plan (includes testing gestures)
Manually tested SwipeableThread since it imports Swipeable from RNGH which is poorly supported and had some changes noted in the breaking changes list

Depends on D5934

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 19 2022, 7:17 AM

Herald added a subscriber: atul. · View Herald TranscriptDec 19 2022, 7:17 AM

Harbormaster failed remote builds in B14319: Diff 19562!Dec 19 2022, 7:19 AM

ashoat added a child revision: D5936: [native] [35/40] RN 0.70: Update to react-native-device-info@10.3.0.Dec 19 2022, 7:19 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 7:19 AM

ashoat mentioned this in D5898: [native] [4/40] RN 0.70: Android stuff.Dec 19 2022, 8:12 AM

Rebase

Harbormaster failed remote builds in B14358: Diff 19607!Dec 19 2022, 8:44 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 9:12 AM

Harbormaster failed remote builds in B14391: Diff 19640!

Please ignore CI until the end of the stack

Rebase

Harbormaster failed remote builds in B14413: Diff 19664!Dec 19 2022, 10:03 AM

Rebase

Harbormaster failed remote builds in B14423: Diff 19675!Dec 19 2022, 11:12 AM

Rebase

Harbormaster failed remote builds in B14458: Diff 19713!Dec 19 2022, 12:48 PM

Rebase

Harbormaster completed remote builds in B14481: Diff 19737.Dec 19 2022, 3:50 PM

bartek accepted this revision.Dec 20 2022, 3:41 AM

This revision is now accepted and ready to land.Dec 20 2022, 3:41 AM

Rebase

Harbormaster completed remote builds in B14514: Diff 19771.Dec 20 2022, 6:52 AM

tomek accepted this revision.Dec 20 2022, 8:49 AM

In D185 we're ignoring a warning regarding ForceTouchGestureHandler. Does this update allow us removing the ignoring?

Unfortunately, no... I'm still seeing this error:

2022-12-20 11.52.23.png (2×1 px, 391 KB)

However, it's looking like the "Please report: Excessive number of pending callbacks" ignoreWarnings from D185 might be possible to remove! I'll look into this after landing the stack.

Rebase

Harbormaster completed remote builds in B14573: Diff 19833.Dec 20 2022, 11:46 AM

Closed by commit rCOMM15386f745850: [native] [34/40] RN 0.70: Update to react-native-gesture-handler@2.8.0 (authored by ashoat). · Explain WhyDec 20 2022, 12:01 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM15386f745850: [native] [34/40] RN 0.70: Update to react-native-gesture-handler@2.8.0.

D5960 removes the Reanimated warning

[native] [34/40] RN 0.70: Update to react-native-gesture-handler@2.8.0
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 19874

native/android/app/src/main/java/app/comm/android/MainActivity.java

native/chat/swipeable-message.react.js

native/flow-typed/npm/react-native-gesture-handler_v1.x.x.js

native/flow-typed/npm/react-native-gesture-handler_v2.x.x.js

native/ios/Podfile.lock

native/package.json

native/root.react.js

yarn.lock

[native] [34/40] RN 0.70: Update to react-native-gesture-handler@2.8.0ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 19874

native/android/app/src/main/java/app/comm/android/MainActivity.java

native/chat/swipeable-message.react.js

native/flow-typed/npm/react-native-gesture-handler_v1.x.x.js

native/flow-typed/npm/react-native-gesture-handler_v2.x.x.js

native/ios/Podfile.lock

native/package.json

native/root.react.js

yarn.lock

[native] [34/40] RN 0.70: Update to react-native-gesture-handler@2.8.0
ClosedPublic
Actions

Revision Contents
Changeset List