Page MenuHomePhabricator
Differential D5895

[native] [1/40] RN 0.70: Update React Native patchfile
ClosedPublic
Actions

Authored by ashoat on Dec 17 2022, 7:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 5:17 AM
Unknown Object (File)
Sun, Nov 10, 5:55 PM
Unknown Object (File)
Wed, Nov 6, 7:10 PM
Unknown Object (File)
Wed, Nov 6, 6:25 AM
Unknown Object (File)
Wed, Nov 6, 6:24 AM
Unknown Object (File)
Sat, Nov 2, 3:32 AM
Unknown Object (File)
Sat, Nov 2, 3:32 AM
Unknown Object (File)
Sat, Nov 2, 3:32 AM
View All Files
Subscribers
atul

Details

Reviewers
tomek
bartek
Commits
rCOMMe0256f5ef778: [native] [1/40] RN 0.70: Update React Native patchfile
Summary

Our current patchfile has three patches: https://www.notion.so/commapp/React-Native-0-66-patchfile-a24a52cbf10a408e96a43822facfd5d7

The new patchfile only has one: https://www.notion.so/commapp/React-Native-0-70-patchfile-e54796687eb2449585e3076e2abf5ee2

The project.pbxproj instability fix was merged upstream, and the Folly build hacks appear to no longer be necessary (presumably because all the files we need are now included in the default build)

Depends on D5894

Test Plan

Tested along with whole stack: test plan

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 17 2022, 7:17 PM
Herald added a subscriber: atul. · View Herald TranscriptDec 17 2022, 7:17 PM
ashoat added a child revision: D5896: [native] [2/40] RN 0.70: Podfile update.Dec 17 2022, 7:21 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 17 2022, 7:21 PM
Harbormaster failed remote builds in B14224: Diff 19458!
ashoat requested review of this revision.Dec 17 2022, 8:07 PM

Please ignore CI until the end of the stack

tomek accepted this revision.Dec 19 2022, 4:26 AM
This revision is now accepted and ready to land.Dec 19 2022, 4:26 AM
bartek accepted this revision.Dec 19 2022, 5:57 AM
ashoat updated this revision to Diff 19800.Dec 20 2022, 10:59 AM

Rebase

Harbormaster failed remote builds in B14540: Diff 19800!Dec 20 2022, 11:00 AM
This revision was landed with ongoing or failed builds.Dec 20 2022, 12:00 PM
Closed by commit rCOMMe0256f5ef778: [native] [1/40] RN 0.70: Update React Native patchfile (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMe0256f5ef778: [native] [1/40] RN 0.70: Update React Native patchfile.

Revision Contents
Changeset List

PathSize
patches/
react-native+0.70.6.patch
react-native+0.66.5.patch
69 lines

Diff 19841

View Options

patches/react-native+0.66.5.patch

Loading...
View Options

patches/react-native+0.70.6.patch

Loading...