Page MenuHomePhabricator

[native] [29/40] RN 0.70: Patch react-native-firebase to avoid importing ViewPropTypes
ClosedPublic

Authored by ashoat on Dec 18 2022, 8:00 PM.
Tags
None
Referenced Files
F3230922: D5924.id19828.diff
Tue, Nov 12, 9:38 AM
F3228398: D5924.id19828.diff
Tue, Nov 12, 1:51 AM
Unknown Object (File)
Sun, Nov 10, 5:54 PM
Unknown Object (File)
Thu, Nov 7, 12:18 PM
Unknown Object (File)
Wed, Nov 6, 7:11 PM
Unknown Object (File)
Wed, Nov 6, 6:25 AM
Unknown Object (File)
Tue, Nov 5, 7:28 AM
Unknown Object (File)
Mon, Nov 4, 4:07 PM
Subscribers

Details

Summary

The new version of React Native finally removed this export. We're using an ancient version of react-native-firebase, context on why here.

The right long-term solution is to migrate all of our Android notifs logic to be using our own modules, but in order to unblock the React Native update I'm just patching this now.

Depends on D5923

Test Plan
  1. Confirm JS error due to ViewPropTypes import no longer occurs
  2. Tested along with whole stack: test plan (includes testing notifs on Android)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:01 PM
Harbormaster failed remote builds in B14253: Diff 19492!
ashoat retitled this revision from [native] [28/40] RN 0.70: Patch react-native-firebase to avoid importing ViewPropTypes to [native] [29/40] RN 0.70: Patch react-native-firebase to avoid importing ViewPropTypes.Dec 18 2022, 8:06 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 9:35 PM
Harbormaster failed remote builds in B14301: Diff 19540!
ashoat published this revision for review.Dec 19 2022, 9:11 AM

Please ignore CI until the end of the stack

This revision is now accepted and ready to land.Dec 20 2022, 5:29 AM