Page MenuHomePhabricator

[native] [18/40] RN 0.70: Fix custom icons in dev mode
ClosedPublic

Authored by ashoat on Dec 18 2022, 9:06 AM.
Tags
None
Referenced Files
F3231409: D5912.id19480.diff
Tue, Nov 12, 11:22 AM
Unknown Object (File)
Sun, Nov 10, 5:55 PM
Unknown Object (File)
Sat, Nov 9, 12:12 PM
Unknown Object (File)
Fri, Nov 8, 1:21 PM
Unknown Object (File)
Mon, Nov 4, 8:20 PM
Unknown Object (File)
Mon, Nov 4, 7:44 PM
Unknown Object (File)
Mon, Nov 4, 7:08 PM
Unknown Object (File)
Mon, Nov 4, 6:32 PM
Subscribers

Details

Summary

expo-dev-client isn't able to show these fonts unless we preload them. This diff resolves ENG-2395, and it gets rid of the warning from ENG-1978.

Depends on D5911

Test Plan

Tested along with whole stack: test plan

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 9:07 AM
Harbormaster failed remote builds in B14241: Diff 19480!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:23 PM
Harbormaster failed remote builds in B14263: Diff 19502!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:53 PM
Harbormaster failed remote builds in B14290: Diff 19529!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 8:32 AM
Harbormaster failed remote builds in B14342: Diff 19591!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 9:01 AM
Harbormaster failed remote builds in B14375: Diff 19624!

Please ignore CI until the end of the stack

This revision is now accepted and ready to land.Dec 20 2022, 3:13 AM
This revision was landed with ongoing or failed builds.Dec 20 2022, 12:01 PM
This revision was automatically updated to reflect the committed changes.