Page MenuHomePhabricator

[native] [12/40] RN 0.70: Update to react-native-video@5.2.1
ClosedPublic

Authored by ashoat on Dec 17 2022, 8:02 PM.
Tags
None
Referenced Files
F3229081: D5906.id19852.diff
Tue, Nov 12, 4:34 AM
F3229051: D5906.id19852.diff
Tue, Nov 12, 4:25 AM
Unknown Object (File)
Sun, Nov 10, 5:55 PM
Unknown Object (File)
Fri, Nov 8, 7:35 AM
Unknown Object (File)
Mon, Nov 4, 8:24 AM
Unknown Object (File)
Mon, Nov 4, 8:24 AM
Unknown Object (File)
Mon, Nov 4, 8:24 AM
Unknown Object (File)
Mon, Nov 4, 3:12 AM
Subscribers

Details

Summary

Upgrade necessary due to this issue that occurs on React Native 0.69.

Depends on D5905

Test Plan

Tested along with whole stack: test plan

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 17 2022, 8:03 PM
Harbormaster failed remote builds in B14235: Diff 19469!
native/react-native.config.js
8 ↗(On Diff #19469)

We used to force some old version of the Android video player (the non-Exoplayer one) for compatibility with old versions of Android, but we don't support those versions anymore, and the new version of react-native-video only supports Exoplayer anyways

patches/react-native-video+5.2.1.patch
10 ↗(On Diff #19469)

This was necessary for the build to succeed, since otherwise the tag pointed to nothing. This appears to have been fixed in the repo but I can't find a non-beta release with the fix...

Please ignore CI until the end of the stack

This revision is now accepted and ready to land.Dec 19 2022, 8:59 AM
This revision was landed with ongoing or failed builds.Dec 20 2022, 12:00 PM
This revision was automatically updated to reflect the committed changes.