Page MenuHomePhabricator
Differential D5908

[native] [14/40] RN 0.70: Add expo-dev-client, expo-dev-menu, expo-dev-launcher
ClosedPublic
Actions

Authored by ashoat on Dec 18 2022, 8:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 7:34 AM
Unknown Object (File)
Tue, Mar 11, 4:45 AM
Unknown Object (File)
Fri, Mar 7, 7:10 AM
Unknown Object (File)
Wed, Mar 5, 6:45 PM
Unknown Object (File)
Mon, Mar 3, 5:01 PM
Unknown Object (File)
Mon, Mar 3, 5:01 PM
Unknown Object (File)
Mon, Mar 3, 5:01 PM
Unknown Object (File)
Mon, Mar 3, 5:01 PM
View All Files
Subscribers
atul

Details

Reviewers
tomek
bartek
• jon
Commits
rCOMM6a99450a6a44: [native] [14/40] RN 0.70: Add expo-dev-client, expo-dev-menu, expo-dev-launcher
Summary

Context here on why we're getting rid of Flipper and replacing with expo-dev-client.

Depends on D5907

Test Plan

Tested along with whole stack: test plan

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 18 2022, 8:24 AM
Herald added a reviewer: • jon. · View Herald TranscriptDec 18 2022, 8:24 AM
Herald added a subscriber: atul. · View Herald Transcript
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:25 AM
Harbormaster failed remote builds in B14237: Diff 19475!
ashoat requested review of this revision.Dec 18 2022, 8:26 AM

Please ignore CI until the end of the stack

docs/dev_environment.md
819 ↗(On Diff #19475)

Handled in a subsequent diff

native/ios/Podfile
75 ↗(On Diff #19475)

Needed to add -DRNVERSION=70 to get things to build

ashoat added a child revision: D5909: [native] [15/40] RN 0.70: Add react-devtools to workflow.Dec 18 2022, 8:43 AM
ashoat updated this revision to Diff 19498.Dec 18 2022, 8:15 PM

Rebase

Harbormaster failed remote builds in B14259: Diff 19498!Dec 18 2022, 8:18 PM
ashoat updated this revision to Diff 19525.Dec 18 2022, 8:29 PM

Rebase

Harbormaster failed remote builds in B14286: Diff 19525!Dec 18 2022, 8:51 PM
bartek added inline comments.Dec 19 2022, 8:07 AM
native/package.json
66 ↗(On Diff #19525)

The same comment as in https://phab.comm.dev/D5907#inline-39929

ashoat updated this revision to Diff 19587.Dec 19 2022, 8:20 AM

Rebase

Harbormaster failed remote builds in B14338: Diff 19587!Dec 19 2022, 8:32 AM
ashoat updated this revision to Diff 19620.Dec 19 2022, 8:36 AM

Rebase

Harbormaster failed remote builds in B14371: Diff 19620!Dec 19 2022, 9:02 AM
ashoat changed 2 blocking reviewer(s), added 1: bartek; removed 1: • jon.Dec 19 2022, 9:45 AM
ashoat updated this revision to Diff 19693.Dec 19 2022, 12:28 PM

Replace caret with squiggle

bartek accepted this revision.Dec 19 2022, 12:29 PM
This revision is now accepted and ready to land.Dec 19 2022, 12:29 PM
Harbormaster failed remote builds in B14438: Diff 19693!Dec 19 2022, 12:34 PM
tomek accepted this revision.Dec 20 2022, 4:53 AM
ashoat updated this revision to Diff 19813.Dec 20 2022, 11:00 AM

Rebase

Harbormaster failed remote builds in B14553: Diff 19813!Dec 20 2022, 11:14 AM
This revision was landed with ongoing or failed builds.Dec 20 2022, 12:00 PM
Closed by commit rCOMM6a99450a6a44: [native] [14/40] RN 0.70: Add expo-dev-client, expo-dev-menu, expo-dev-launcher (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM6a99450a6a44: [native] [14/40] RN 0.70: Add expo-dev-client, expo-dev-menu, expo-dev-launcher.

Revision Contents
Changeset List

PathSize
docs/
4 lines
4 lines
native/
3 lines
ios/
Comm.xcodeproj/
8 lines
5 lines
106 lines
5 lines
50 lines

Diff 19854

View Options

docs/dev_environment.md

<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<manifest <manifest
xmlns:android="http://schemas.android.com/apk/res/android" xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools" xmlns:tools="http://schemas.android.com/tools"
> >
<uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/> <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>
<application <application
android:usesCleartextTraffic="true" android:usesCleartextTraffic="true"
tools:targetApi="28" tools:targetApi="28"
tools:ignore="GoogleAppIndexingWarning"> tools:ignore="GoogleAppIndexingWarning">
<activity android:name="com.facebook.react.devsupport.DevSettingsActivity" /> <activity android:name="com.facebook.react.devsupport.DevSettingsActivity" android:exported="false" />
</application> </application>
</manifest> </manifest>
View Options

docs/nix_web_workflows.md

<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<manifest <manifest
xmlns:android="http://schemas.android.com/apk/res/android" xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools" xmlns:tools="http://schemas.android.com/tools"
> >
<uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/> <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>
<application <application
android:usesCleartextTraffic="true" android:usesCleartextTraffic="true"
tools:targetApi="28" tools:targetApi="28"
tools:ignore="GoogleAppIndexingWarning"> tools:ignore="GoogleAppIndexingWarning">
<activity android:name="com.facebook.react.devsupport.DevSettingsActivity" /> <activity android:name="com.facebook.react.devsupport.DevSettingsActivity" android:exported="false" />
</application> </application>
</manifest> </manifest>
View Options

native/.gitignore

<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<manifest <manifest
xmlns:android="http://schemas.android.com/apk/res/android" xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools" xmlns:tools="http://schemas.android.com/tools"
> >
<uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/> <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>
<application <application
android:usesCleartextTraffic="true" android:usesCleartextTraffic="true"
tools:targetApi="28" tools:targetApi="28"
tools:ignore="GoogleAppIndexingWarning"> tools:ignore="GoogleAppIndexingWarning">
<activity android:name="com.facebook.react.devsupport.DevSettingsActivity" /> <activity android:name="com.facebook.react.devsupport.DevSettingsActivity" android:exported="false" />
</application> </application>
</manifest> </manifest>
View Options

native/ios/Comm.xcodeproj/project.pbxproj

<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<manifest <manifest
xmlns:android="http://schemas.android.com/apk/res/android" xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools" xmlns:tools="http://schemas.android.com/tools"
> >
<uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/> <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>
<application <application
android:usesCleartextTraffic="true" android:usesCleartextTraffic="true"
tools:targetApi="28" tools:targetApi="28"
tools:ignore="GoogleAppIndexingWarning"> tools:ignore="GoogleAppIndexingWarning">
<activity android:name="com.facebook.react.devsupport.DevSettingsActivity" /> <activity android:name="com.facebook.react.devsupport.DevSettingsActivity" android:exported="false" />
</application> </application>
</manifest> </manifest>
View Options

native/ios/Podfile

Loading...
View Options

native/ios/Podfile.lock

Loading...
View Options

native/package.json

Loading...
View Options

yarn.lock

Loading...