Details

Reviewers

tomek
bartek
• jon

Commits

rCOMM6a99450a6a44: [native] [14/40] RN 0.70: Add expo-dev-client, expo-dev-menu, expo-dev-launcher

Summary

Context here on why we're getting rid of Flipper and replacing with expo-dev-client.

Depends on D5907

Test Plan

Tested along with whole stack: test plan

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 18 2022, 4:24 PM

Herald added a reviewer: • jon. · View Herald TranscriptDec 18 2022, 4:24 PM

Herald added a subscriber: atul. · View Herald Transcript

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 4:25 PM

Harbormaster failed remote builds in B14237: Diff 19475!

Please ignore CI until the end of the stack

docs/dev_environment.md
819 ↗	(On Diff #19475)	Handled in a subsequent diff
native/ios/Podfile
75 ↗	(On Diff #19475)	Needed to add `-DRNVERSION=70` to get things to build

ashoat added a child revision: D5909: [native] [15/40] RN 0.70: Add react-devtools to workflow.Dec 18 2022, 4:43 PM

Rebase

Harbormaster failed remote builds in B14259: Diff 19498!Dec 19 2022, 4:18 AM

Rebase

Harbormaster failed remote builds in B14286: Diff 19525!Dec 19 2022, 4:51 AM

bartek added inline comments.Dec 19 2022, 4:07 PM

native/package.json
66 ↗	(On Diff #19525)	The same comment as in https://phab.comm.dev/D5907#inline-39929

Rebase

Harbormaster failed remote builds in B14338: Diff 19587!Dec 19 2022, 4:32 PM

Rebase

Harbormaster failed remote builds in B14371: Diff 19620!Dec 19 2022, 5:02 PM

ashoat changed 2 blocking reviewer(s), added 1: bartek; removed 1: • jon.Dec 19 2022, 5:45 PM

Replace caret with squiggle

bartek accepted this revision.Dec 19 2022, 8:29 PM

This revision is now accepted and ready to land.Dec 19 2022, 8:29 PM

Harbormaster failed remote builds in B14438: Diff 19693!Dec 19 2022, 8:34 PM

tomek accepted this revision.Dec 20 2022, 12:53 PM

Rebase

Harbormaster failed remote builds in B14553: Diff 19813!Dec 20 2022, 7:14 PM

This revision was landed with ongoing or failed builds.Dec 20 2022, 8:00 PM

Closed by commit rCOMM6a99450a6a44: [native] [14/40] RN 0.70: Add expo-dev-client, expo-dev-menu, expo-dev-launcher. · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM6a99450a6a44: [native] [14/40] RN 0.70: Add expo-dev-client, expo-dev-menu, expo-dev-launcher.

[native] [14/40] RN 0.70: Add expo-dev-client, expo-dev-menu, expo-dev-launcher
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 19854

docs/dev_environment.md

docs/nix_web_workflows.md

native/.gitignore

native/ios/Comm.xcodeproj/project.pbxproj

native/ios/Podfile

native/ios/Podfile.lock

native/package.json

yarn.lock

[native] [14/40] RN 0.70: Add expo-dev-client, expo-dev-menu, expo-dev-launcherClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 19854

docs/dev_environment.md

docs/nix_web_workflows.md

native/.gitignore

native/ios/Comm.xcodeproj/project.pbxproj

native/ios/Podfile

native/ios/Podfile.lock

native/package.json

yarn.lock

[native] [14/40] RN 0.70: Add expo-dev-client, expo-dev-menu, expo-dev-launcher
ClosedPublic
Actions

Revision Contents
Changeset List