Page MenuHomePhabricator
Differential D5925

[native] [30/40] RN 0.70: Patch react-native-firebase to avoid Android NativeEventEmitter warning
ClosedPublic
Actions

Authored by ashoat on Dec 18 2022, 8:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 7:34 PM
Unknown Object (File)
Fri, Nov 22, 9:15 AM
Unknown Object (File)
Fri, Nov 22, 8:33 AM
Unknown Object (File)
Fri, Nov 22, 8:21 AM
Unknown Object (File)
Fri, Nov 22, 8:04 AM
Unknown Object (File)
Fri, Nov 22, 8:04 AM
Unknown Object (File)
Fri, Nov 22, 7:34 AM
Unknown Object (File)
Wed, Nov 20, 11:51 AM
View All Files
Subscribers
atul

Details

Reviewers
marcin
tomek
bartek
Commits
rCOMMf271afbe4e6e: [native] [30/40] RN 0.70: Patch react-native-firebase to avoid Android…
Summary

Without this change a warning is printed. The methods don't need to be filled in, they just need to be defined. Here's an example of react-native-orientation-locker fixing the same issue.

The right long-term solution is to migrate all of our Android notifs logic to be using our own modules, but in order to unblock the React Native update I'm just patching this now.

Depends on D5924

Test Plan
  1. Confirm Android NativeEventEmitter warning is no longer printed
  2. Tested along with whole stack: test plan (includes testing notifs on Android)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Dec 18 2022, 8:02 PM
Herald added a subscriber: atul. · View Herald TranscriptDec 18 2022, 8:02 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:03 PM
Harbormaster failed remote builds in B14254: Diff 19493!
ashoat retitled this revision from [native] [29/40] RN 0.70: Patch react-native-firebase to avoid Android NativeEventEmitter warning to [native] [30/40] RN 0.70: Patch react-native-firebase to avoid Android NativeEventEmitter warning.Dec 18 2022, 8:06 PM
ashoat updated this revision to Diff 19514.Dec 18 2022, 8:20 PM

Rebase

ashoat updated this revision to Diff 19541.Dec 18 2022, 8:33 PM

Rebase

Harbormaster failed remote builds in B14275: Diff 19514!Dec 18 2022, 8:34 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 9:37 PM
Harbormaster failed remote builds in B14302: Diff 19541!
ashoat added a child revision: D5932: [native] [31/40] RN 0.70: First commit for new AndroidLifecycle Expo module.Dec 19 2022, 7:00 AM
ashoat updated this revision to Diff 19603.Dec 19 2022, 8:22 AM

Rebase

ashoat updated this revision to Diff 19636.Dec 19 2022, 8:38 AM

Rebase

Harbormaster failed remote builds in B14354: Diff 19603!Dec 19 2022, 9:10 AM
ashoat published this revision for review.Dec 19 2022, 9:11 AM

Please ignore CI until the end of the stack

Harbormaster failed remote builds in B14387: Diff 19636!Dec 19 2022, 10:11 AM
ashoat updated this revision to Diff 19709.Dec 19 2022, 12:30 PM

Rebase

Harbormaster failed remote builds in B14454: Diff 19709!Dec 19 2022, 12:54 PM
ashoat updated this revision to Diff 19767.Dec 20 2022, 6:22 AM

Rebase

Harbormaster failed remote builds in B14510: Diff 19767!Dec 20 2022, 6:27 AM
tomek accepted this revision.Dec 20 2022, 7:12 AM
This revision is now accepted and ready to land.Dec 20 2022, 7:12 AM
bartek accepted this revision.Dec 20 2022, 8:33 AM
ashoat updated this revision to Diff 19829.Dec 20 2022, 11:02 AM

Rebase

Harbormaster completed remote builds in B14569: Diff 19829.Dec 20 2022, 11:40 AM
Closed by commit rCOMMf271afbe4e6e: [native] [30/40] RN 0.70: Patch react-native-firebase to avoid Android… (authored by ashoat). · Explain WhyDec 20 2022, 12:01 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMf271afbe4e6e: [native] [30/40] RN 0.70: Patch react-native-firebase to avoid Android….

Revision Contents
Changeset List

PathSize
patches/
38 lines

Diff 19514

View Options

patches/react-native-firebase+5.6.0.patch

Loading...